Closed
Bug 800657
Opened 12 years ago
Closed 12 years ago
Reenable WebGL index-validation.html test
Categories
(Core :: Graphics: CanvasWebGL, defect)
Core
Graphics: CanvasWebGL
Tracking
()
RESOLVED
FIXED
mozilla19
People
(Reporter: bjacob, Assigned: bjacob)
Details
Attachments
(1 file)
2.88 KB,
patch
|
bzbarsky
:
review+
|
Details | Diff | Splinter Review |
It was disabled by b3c814e2d015. It's not too bad, only the large-negative-value test is failing on 32bit machines. Regressed either in bug 732660 or with the porting to new bindings.
Assignee | ||
Comment 1•12 years ago
|
||
This was regressed by: changeset: 109965:4c134de65570 user: Benoit Jacob <bjacob@mozilla.com> date: Thu Oct 11 14:23:34 2012 -0400 summary: Bug 779611 - WebGL extensions should be [NoInterfaceObject] as their compliant IDL interface names would pollute the global object - r=bz
Assignee | ||
Comment 2•12 years ago
|
||
Erm, no, rather by changeset: 109966:78c16f313547 user: Benoit Jacob <bjacob@mozilla.com> date: Thu Oct 11 15:23:03 2012 -0400 summary: Bug 779611 - part 12: remove old-bindings remnants in the WebGL implementation - r=bz
Assignee | ||
Comment 3•12 years ago
|
||
Yeah OK I know what this almost certainly is --- the WebGLintptr typedef was changed to a typedef to GLintptr, and likely these were not actually the same.
Assignee | ||
Comment 4•12 years ago
|
||
OK, indeed: WebGLintptr was long long which is int64 GLintptr is ptrdiff_t. Whence the bug on 32bit platforms
Assignee | ||
Comment 5•12 years ago
|
||
Again, the bug was that while most WebGL types are equal to the corresponding OpenGL type, some are different: WebGLintptr is always long long (int64) in Web IDL while it is intptr_t in OpenGL WebGLsizeiptr is the same I also changed WebGLboolean to be bool, following Web IDL. Also removed now-useless #include "WebGLContext.h" in nsDOMCI. And the #undef None there was almost certainly added there for it (X11 headers have a None macro) and affected WebGLContext.h (which has or used to have a None enum value somewhere). Removed too. Reenabling the unit test.
Attachment #671006 -
Flags: review?(bzbarsky)
Comment 6•12 years ago
|
||
Comment on attachment 671006 [details] [diff] [review] fix WebGL typedefs to reflect IDL types instead of being equal to OpenGL types r=me
Attachment #671006 -
Flags: review?(bzbarsky) → review+
Assignee | ||
Comment 7•12 years ago
|
||
http://hg.mozilla.org/integration/mozilla-inbound/rev/39d70a2e0dea
Target Milestone: --- → mozilla19
Comment 8•12 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/39d70a2e0dea
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Assignee | ||
Comment 9•12 years ago
|
||
Somehow, the part of that patch that actually reenables the test was dropped. Landed now: http://hg.mozilla.org/integration/mozilla-inbound/rev/088dfedf36d5
Comment 10•12 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/088dfedf36d5
Flags: in-testsuite+
You need to log in
before you can comment on or make changes to this bug.
Description
•