Closed
Bug 801080
Opened 12 years ago
Closed 12 years ago
window.close will not close social panels
Categories
(Firefox Graveyard :: SocialAPI, defect)
Firefox Graveyard
SocialAPI
Tracking
(firefox17+ verified, firefox18+ verified)
VERIFIED
FIXED
Firefox 19
People
(Reporter: Gavin, Assigned: markh)
References
Details
(Whiteboard: [Fx17])
Attachments
(1 file)
|
2.94 KB,
patch
|
Felipe
:
review+
Gavin
:
approval-mozilla-aurora+
Gavin
:
approval-mozilla-beta+
|
Details | Diff | Splinter Review |
+++ This bug was initially created as a clone of Bug #799592 +++ Morphing bug 799592 to cover the core fix. We'll need a social front-end fix to use the new API being introduced there.
|
Assignee | |
Comment 1•12 years ago
|
||
Assignee: nobody → mhammond
Attachment #671673 -
Flags: review?(jaws)
|
||
Updated•12 years ago
|
Attachment #671673 -
Flags: review?(jaws) → review+
|
|
Assignee | |
Comment 2•12 years ago
|
||
there was a stray dump() in the test which I removed. https://hg.mozilla.org/integration/mozilla-inbound/rev/bf5f5e60f37c
|
Reporter | |
Updated•12 years ago
|
Attachment #671673 -
Flags: approval-mozilla-beta+
Attachment #671673 -
Flags: approval-mozilla-aurora+
|
|
Reporter | |
Comment 3•12 years ago
|
||
https://hg.mozilla.org/releases/mozilla-aurora/rev/51f6d986d9cd https://hg.mozilla.org/releases/mozilla-beta/rev/d1fff984c152
status-firefox17:
--- → fixed
status-firefox18:
--- → fixed
|
||
Comment 4•12 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/bf5f5e60f37c
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 19
It looks like the patch landing includes tests. Is this correct?
Flags: in-testsuite?
|
|
Assignee | |
Updated•12 years ago
|
Flags: in-testsuite? → in-testsuite+
Thanks Mark. Verified fixed based on tests.
|
||
Updated•5 years ago
|
Product: Firefox → Firefox Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•