Closed Bug 801086 Opened 12 years ago Closed 11 years ago

Ensure selected tab is fully visible upon opening tab bar

Categories

(Firefox for Metro Graveyard :: General, defect, P1)

Product:
Firefox for Metro Graveyard
Component:
General
Platform:
x86
Windows 8.1
Type:
defect

Tracking

(Not tracked)

Status:
RESOLVED FIXED

People

(Reporter: ally, Assigned: fryn)

References

Details

(Keywords: polish, Whiteboard: completed-elm [metro-mvp] [LOE:1] [metro-it1])

Attachments

(1 file)

patch
2.93 KB, patch
mbrubeck
: review+
Details | Diff | Splinter Review 
      No description provided.
OS: Mac OS X → Windows 8 Metro
Blocks: 803928
Keywords: feature → polish
Priority: -- → P1
Whiteboard: [metro-mvp] → [metro-mvp] [LOE:1]
Frank, would you like to work on this?
Assignee: nobody → fryn
or Sam?
Assignee: fryn → nobody
Assignee: nobody → fryn
Status: NEW → ASSIGNED
Summary: autoscroll to new or selected tab → Ensure selected tab is fully visible upon opening tab bar
Whiteboard: [metro-mvp] [LOE:1] → [metro-mvp] [LOE:1] [metro-it1]
Attached patch patch — — Splinter Review 
Fixed! :)

Using .children as a XUL field is not okay, because there is already a DOM property called that.
The DOM property .children returns the subset of .childNodes that are DOM elements.
Attachment #682121 - Flags: review?(mbrubeck)
Comment on attachment 682121 [details] [diff] [review]
patch

Nice.
Attachment #682121 - Flags: review?(mbrubeck) → review+
https://hg.mozilla.org/projects/elm/rev/b5104d1c1a4a
Whiteboard: [metro-mvp] [LOE:1] [metro-it1] → completed-elm [metro-mvp] [LOE:1] [metro-it1]
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
OS: Windows 8 Metro → Windows 8.1
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: