801261 - Adopt editContactOverlay to new light coloring

Status: RESOLVED FIXED

(Thunderbird :: Theme, defect)

Description

[Richard Marti (:Paenglab)]

Bug 771284 changed the way arrow panels look (dark --> light). We should adjust the css for our editContactOverlay to look similar.

Comment 1

[Richard Marti (:Paenglab)]

Attachment: patch

Change the panel from dark to light.

Additionally I added a min-height: 48px; for all themes because the star is squished when text is shown under the menulist.

Comment 2

[Richard Marti (:Paenglab)]

Attachment: Screenshot with patch applied for easier ui-r

Comment 3

[Richard Marti (:Paenglab)]

Attachment: Screenshot showing the squished star under Linux

Comment 4

[Blake Winton (:bwinton) (:☕️)]

Comment on attachment 671054 [details] [diff] [review]
patch

Yeah, that seems to make sense.  ui-r=me.

>+++ b/mail/themes/gnomestripe/mail/editContactOverlay.css
>+++ b/mail/themes/pinstripe/mail/editContactOverlay.css
>+++ b/mail/themes/qute/mail/editContactOverlay.css

And the code seems good, too, so r=me, while we're at it.

(I thought we might need an aero-version, but it looks like we don't.)

Thanks,
Blake.

Comment 5

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/comm-central/rev/8a8cca521c71