802381 - fix clang build

Status: RESOLVED FIXED

(Core :: IPC, defect)

Description

[Rafael Ávila de Espíndola (:espindola) (not reading bugmail)]

Attachment: cast via intptr_t

Newer clangs have this warning:

error: cast to 'void *' from smaller integer type 'int'

which in combination with -Werror causes the build to fail without this patch. I don't know the code, so I am assuming that the value is not actually a pointer, it is just being casted to one to fit in an old existing API, is that the case?

Comment 1

[Rafael Ávila de Espíndola (:espindola) (not reading bugmail)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/c33b8a63580c

Comment 2

[(no longer active)]

https://hg.mozilla.org/mozilla-central/rev/c33b8a63580c

Comment 3

[Rafael Ávila de Espíndola (:espindola) (not reading bugmail)]

Comment on attachment 672047 [details] [diff] [review]
cast via intptr_t

This is needed for bug 799572.

[Approval Request Comment]
Bug caused by (feature/regressing bug #): 
User impact if declined: 
Testing completed (on m-c, etc.): 
Risk to taking this patch (and alternatives if risky): 
String or UUID changes made by this patch:

Comment 4

[bhavana bajaj [:bajaj]]

Comment on attachment 672047 [details] [diff] [review]
cast via intptr_t

Approving as it is needed by 799572

Comment 5

[Scoobidiver (away)]

Pushed to Aurora:
http://hg.mozilla.org/releases/mozilla-aurora/rev/3e9a1114bd92