Closed
Bug 802466
Opened 12 years ago
Closed 12 years ago
Youtube stream url requires signature
Categories
(Firefox OS Graveyard :: General, defect, P1)
Tracking
(blocking-basecamp:+, firefox18 fixed, firefox19 fixed)
RESOLVED
FIXED
blocking-basecamp | + |
People
(Reporter: daleharvey, Assigned: daleharvey)
References
Details
Attachments
(1 file, 1 obsolete file)
1.06 KB,
patch
|
Details | Diff | Splinter Review |
Changes to youtubes api require a signature to be provided
Assignee | ||
Comment 1•12 years ago
|
||
Assignee: nobody → dale
Attachment #672141 -
Flags: review?(fabrice)
Updated•12 years ago
|
OS: Mac OS X → Gonk
Hardware: x86 → All
Comment 2•12 years ago
|
||
Comment on attachment 672141 [details] [diff] [review] Bug 802466 - Add signature to stream url. r=fabrice Review of attachment 672141 [details] [diff] [review]: ----------------------------------------------------------------- r=me with nit addressed. ::: b2g/components/YoutubeProtocolHandler.js @@ +92,5 @@ > > let index; > if (url && type && ((index = recognizedTypes.indexOf(type)) != -1) && > index > bestType) { > + uri = url + '&signature=' + params['sig']; we need to guard against params['sig'] being null
Attachment #672141 -
Flags: review?(fabrice) → review+
Assignee | ||
Comment 3•12 years ago
|
||
Added null check
Attachment #672141 -
Attachment is obsolete: true
Assignee | ||
Updated•12 years ago
|
blocking-basecamp: --- → ?
Assignee | ||
Updated•12 years ago
|
Attachment #672254 -
Flags: review+
Assignee | ||
Updated•12 years ago
|
Keywords: checkin-needed
Whiteboard: [needs-checkin-aurora]
Assignee | ||
Updated•12 years ago
|
Attachment #672254 -
Flags: review+
Updated•12 years ago
|
Whiteboard: [needs-checkin-aurora]
Updated•12 years ago
|
Blocks: youtube.com
blocking-basecamp: ? → +
Comment 5•12 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/d896a7f47e02
Keywords: checkin-needed
Comment 6•12 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/d896a7f47e02
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Comment 7•12 years ago
|
||
https://hg.mozilla.org/releases/mozilla-aurora/rev/915d0d6c7967
status-firefox18:
--- → fixed
status-firefox19:
--- → fixed
You need to log in
before you can comment on or make changes to this bug.
Description
•