802887 - CC graph size regression possibly because of some JS changes in UI

Status: RESOLVED INCOMPLETE

(Firefox :: General, defect)

Description

[Olli Pettay [:smaug][[e-mail]]]

For some reason I'm seeing significantly larger CC graphs especially
if I have many tabs open. Each tabs seems to add quite a bit to the graph.
This is with Nightly (which doesn't yet have the eventlistenermanager nor framemessagemanager related changes I landed earlier today.)

Comment 1

[Olli Pettay [:smaug][[e-mail]]]

Lots of JS stuff.

Comment 2

[Olli Pettay [:smaug][[e-mail]]]

...which seem to be coming from newtab.js
I wonder if we have changed something there

Comment 3

[Olli Pettay [:smaug][[e-mail]]]

Doesn't seem to be anything recent. I wonder why I haven't noticed this before.

Comment 4

[Tim Taubert [:ttaubert] (inactive)]

So what does that mean? What exactly is newtab.js doing wrong?

Comment 5

[Olli Pettay [:smaug][[e-mail]]]

It is probably not doing anything wrong, but for some reason the stuff in it end up
to the graph. Perhaps that is the bug with XULprototypescript which Andrew has been
looking at.
But there is also something else. Each tab seems to add about 300 objects to the graph.
I think that number has gone up. Maybe it is gradual regression.

Comment 6

[Olli Pettay [:smaug][[e-mail]]]

And now I'm not seeing the stuff in the graph. Odd.
Though, the latest Nightly has few optimizations.

Comment 7

[Olli Pettay [:smaug][[e-mail]]]

So I think I figured this out.
each about:newtab ends up adding 350 objects to the graph. But the problem is all about
XULPrototypeNode and we have existing bug about that.