803040 - [Clock] Time picker messes up when (1) set alarm (2) kill app (3) alarm fires

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia, defect, P3)

Description

[Gene Lian (I already quit Mozilla)]

## STR:
  1. Launch the clock app.
  2. Set an alarm to fire in about 1 min.
  3. Long-push the homescreen button to kill the clock app.
  4. Wait on the alarm firing.
  5. Open the clock app.
  6. Reset the previous alarm at #2 or set another new alarm.

## Expected:
  A normal time picker should be displayed.

## Actual:
  The time picker messes up.

Comment 1

[John Hammink]

Unagi build 10/17/12

Time picker second time contains no actual numbers.

Comment 2

[Naoki Hirata :nhirata (please use needinfo instead of cc)]

I believe that this is a dup of bug 796831 which is marked a dup of bug 799644.

clee, I would like to have bug 799644 set as a higher priority as it happens all over the place in b2g.

Comment 3

[Tim Guan-tin Chien [:timdream] (please needinfo)]

Ian said this should be a bug in Clock regarding init calling sequence.

Comment 4

[Naoki Hirata :nhirata (please use needinfo instead of cc)]

This somewhat still occurs.  I had the time picker show numbers, but when I scrolled the numbers scrolled off the screen until it became blank.

Otoro phone, build 2012-10-23
Taken from default.xml in b2g-distro: 
* "platform_build" revision= db539a3bd139c93c09b0cd1c3f9396b74d68717c
* "gaia" revision= 0b8ec9b8c16429dc35453dbb7b9342fab3dd18fb 
* "releases-mozilla-aurora" revision= f58edfde05cb708f8a2c440d338f2e429aaf372b
* "gonk-misc" revision= db0c751715f4696515735eb1e0dc5df7a40eb81d

Comment 5

[Naoki Hirata :nhirata (please use needinfo instead of cc)]

Can't seem to reproduce this without killing the clock app.  This particular bug is only in the clock app as far as I can tell...

Comment 6

[Mike Connor [:mconnor]]

P3, qawanted: Can we get a screenshot, and an assessment of whether this is visual disruption only, or actual functional bustage.  If the former, can you renominate so we can re-assess this bug?

Comment 7

[John Shih]

I can't reproduce this follow the STR
Gene, can you check it again?

Comment 8

[[e-mail], [e-mail]]

(In reply to John Shih from comment #7)
> I can't reproduce this follow the STR
> Gene, can you check it again?
Hi John,

I can reproduce it.
I'll take over it.
Thanks for your check.

Comment 9

[[e-mail], [e-mail]]

Attachment: Pointer to Github pull request: https://github.com/mozilla-b2g/gaia/pull/6105

Pointer to Github pull-request

Comment 10

[[e-mail], [e-mail]]

Comment on attachment 676922 [details]
Pointer to Github pull request: https://github.com/mozilla-b2g/gaia/pull/6105

The picker got wrong value of the client height when Clock APP is launching and initial in the background.
It will make the picker messes up with wrong offset height.

We only need to initial the picker when Clock APP really goes into alarm-edit page.

Comment 11

[Rudy Lu [:rudyl] (inactive after 2015/7/3)]

Comment on attachment 676922 [details]
Pointer to Github pull request: https://github.com/mozilla-b2g/gaia/pull/6105

Looks good to me.
r+

Comment 12

[Rudy Lu [:rudyl] (inactive after 2015/7/3)]

Fixed with https://github.com/mozilla-b2g/gaia/pull/6105.

Comment 13

[Rebecca Billings [:rbillings]]

Verified able to set multiple consecutive alarms with no issues on the time picker.

Comment 14

[Naoki Hirata :nhirata (please use needinfo instead of cc)]

removing QAwanted since rebecca verified the fix for this bug.