803167 - build option to enable/disable the network geolocation provider.

Status: NEW

(Firefox Build System :: General, defect)

Description

[Doug Turner (:dougt)]

Currently, we build the network geolocation provider (/dom/system/NetworkGeolocationProvider.js) on almost all platforms.  The implementation is tightly coupled to the Google Location Service.  It really shouldn't be part of B2G or XR without someone specifically enabling it.  So, instead of configuring this option based on platform type, I'd like to have a specific configure option.


We need to be able to turn off GLS for basecamp.

Comment 1

[Doug Turner (:dougt)]

Attachment: patch v.1

Comment 2

[Mike Hommey [:glandium]]

The problem with these kind of approaches is that is makes is impossible to add it on Firefox-on-Xulrunner builds without making it available to all xulrunner applications. It would be better to enable it with a runtime pref that would be disabled in greprefs.js but enabled at the browser level.

Comment 3

[Mike Hommey [:glandium]]

(In reply to Mike Hommey [:glandium] from comment #2)
> The problem with these kind of approaches is that is makes is impossible to
                                                    it       it

Comment 4

[Mike Hommey [:glandium]]

I think a nice way to fix this for geolocation providers is to register NetworkGeolocationProvider with the category manager, remove the hardcoded registration from dom/src/geolocation/nsGeolocation.cpp, and add code that only adds the geolocation providers gotten from the category-manager if asome pref is set to true. The pref name could be something like the category name prefixed with geo.category. .

Comment 5

[Andrew Overholt [:overholt]]

It's not clear why this should block so I'm going to - it.  Obviously if you disagree, please re-nom and provide a bit of justification.  Thanks.

Comment 6

[Doug Turner (:dougt)]

Who makes Firefox-on-Xulrunner builds?

Comment 7

[Mike Hommey [:glandium]]

(In reply to Doug Turner (:dougt) from comment #6)
> Who makes Firefox-on-Xulrunner builds?

At least Fedora and Debian.

Comment 8

[Doug Turner (:dougt)]

Comment on attachment 672835 [details] [diff] [review]
patch v.1

Review of attachment 672835 [details] [diff] [review]:
-----------------------------------------------------------------

we should go with something like mike suggests.

Comment 9

[Doug Turner (:dougt)]

really, the point of this is so that we don't have people using the GLS API without permission from Google.  Maybe we should just have a preference checked in WifiGeoPositionProvider.start().

Comment 10

[Doug Turner (:dougt)]

Mike,

there is a big difference between:

http://mxr.mozilla.org/mozilla-central/source/browser/confvars.sh
and
http://mxr.mozilla.org/mozilla-central/source/xulrunner/confvars.sh

What does firefox on xul do for the other build configure options?

Comment 11

[Doug Turner (:dougt)]

s/xul/xulrunner

Comment 12

[Mike Hommey [:glandium]]

(In reply to Doug Turner (:dougt) from comment #10)
> Mike,
> 
> there is a big difference between:
> 
> http://mxr.mozilla.org/mozilla-central/source/browser/confvars.sh
> and
> http://mxr.mozilla.org/mozilla-central/source/xulrunner/confvars.sh
> 
> What does firefox on xul do for the other build configure options?

Apart from MOZ_MEDIA_NAVIGATOR, all options in browser/confvars.sh are browser/ specific.

Comment 13

[Doug Turner (:dougt)]

I am thinking about:

20 MOZ_SAFE_BROWSING=1


This is very similar.  Mozilla has a relationship with Google to provider a safe browser API.  The Network Geolocation code is similar.  Wifi/IP to Geolocation is provided by Google via their GLS API.

The Network Geolocation provider should be part of non-firefox XULRunner apps.  the Network Geolocation provider should be part of B2G.

Do we ship Safe Browsing to all xulrunner applications?

Comment 14

[Mike Hommey [:glandium]]

(In reply to Doug Turner (:dougt) from comment #13)
> I am thinking about:
> 
> 20 MOZ_SAFE_BROWSING=1

This enables code that lives under browser/

Comment 15

[Doug Turner (:dougt)]

okay.  That makes sense.

Maybe the best thing is to NetworkGeolocationProvider.js into browser/.  We will have to factor out the testing bits of NetworkGeolocationProvider.js, but that shouldn't be too bad.

Josh -- thoughts on the above?

Comment 16

[Doug Turner (:dougt)]

unassigning things that I am not working on.