Closed Bug 803282 Opened 12 years ago Closed 12 years ago

utilmod.c does not need to include pkcs11t.h and secitem.h

Categories

(NSS :: Libraries, defect, P2)

3.14
defect

Tracking

(Not tracked)

RESOLVED FIXED
3.14.1

People

(Reporter: wtc, Assigned: wtc)

Details

Attachments

(1 file)

Attached patch Proposed patchSplinter Review
This problem was introduced by the last patch (attachment 667517 [details] [diff] [review])
in bug 753116. I noticed this when reviewing the changes between
NSS 3.14 Beta 1 and RC1.

utilpars.h uses the PRArenaPool type. So I have utilpars.h include
plarena.h.

utilmod.c uses several PORT_xxx macros and functions. So I have
utilmod.c include secport.h.  utilmod.c does not need anything
defined or declared in pkcs11t.h or secitem.h.
Attachment #672957 - Flags: review?(emaldona)
Attachment #672957 - Flags: review?(emaldona) → review+
Patch checked in on the NSS trunk (NSS 3.14.1).

Checking in utilmod.c;
/cvsroot/mozilla/security/nss/lib/util/utilmod.c,v  <--  utilmod.c
new revision: 1.6; previous revision: 1.5
done
Checking in utilpars.h;
/cvsroot/mozilla/security/nss/lib/util/utilpars.h,v  <--  utilpars.h
new revision: 1.3; previous revision: 1.2
done
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: