Closed
Bug 803288
Opened 12 years ago
Closed 11 years ago
Disable typed array move() operator for beta
Categories
(Core :: JavaScript Engine, defect)
Core
JavaScript Engine
Tracking
()
People
(Reporter: sfink, Assigned: sfink)
References
Details
(Whiteboard: [js:t])
Attachments
(1 file)
1.05 KB,
patch
|
dmandelin
:
review+
lsblakk
:
approval-mozilla-beta+
|
Details | Diff | Splinter Review |
ArrayBufferView.move is not (yet?) spec'ed, so we don't want it to slip into a release.
Assignee | ||
Comment 1•12 years ago
|
||
This is pretty much the same as https://bugzilla.mozilla.org/attachment.cgi?id=660606 but given that this is going to be landed on beta, I'd rather not just inherit the r+.
Attachment #672968 -
Flags: review?(dmandelin)
Assignee | ||
Comment 2•12 years ago
|
||
Requesting tracking for all releases beta and on because this needs to be re-done for every beta. See also bug 803276.
tracking-firefox17:
--- → ?
tracking-firefox18:
--- → ?
tracking-firefox19:
--- → ?
tracking-firefox-esr17:
--- → ?
Updated•12 years ago
|
Attachment #672968 -
Flags: review?(dmandelin) → review+
Assignee | ||
Comment 3•12 years ago
|
||
Comment on attachment 672968 [details] [diff] [review] Disable typed array move() operator for beta [Approval Request Comment] Bug caused by (feature/regressing bug #): bug 730873 User impact if declined: new method move() on typed arrays exposed to web content. move() is not yet part of any spec, so exposing it introduces backwards compatibility risk. Testing completed (on m-c, etc.): this patch is more or less present on current release, and has been since it was beta Risk to taking this patch (and alternatives if risky): Minimal String or UUID changes made by this patch: none This same change was previously approved for the last beta in bug 786386.
Attachment #672968 -
Flags: approval-mozilla-beta?
Comment 4•12 years ago
|
||
(In reply to Steve Fink [:sfink] from comment #2) > Requesting tracking for all releases beta and on because this needs to be > re-done for every beta. See also bug 803276. We'll approve the current patch for beta, but please make a follow up for Aurora 18 and Nightly 19 such that this pref is automatically disabled on the Beta/Release channels. We shouldn't need to perform the same back out every release.
tracking-firefox-esr17:
? → ---
Assignee | ||
Comment 5•12 years ago
|
||
(In reply to Alex Keybl [:akeybl] from comment #4) > (In reply to Steve Fink [:sfink] from comment #2) > > Requesting tracking for all releases beta and on because this needs to be > > re-done for every beta. See also bug 803276. > > We'll approve the current patch for beta, but please make a follow up for > Aurora 18 and Nightly 19 such that this pref is automatically disabled on > the Beta/Release channels. We shouldn't need to perform the same back out > every release. I don't think we have a proper mechanism for that, which is why I filed bug 803276. Please weigh in on that bug, since I like the status quo even less than you do.
Comment 6•12 years ago
|
||
Comment on attachment 672968 [details] [diff] [review] Disable typed array move() operator for beta Thanks for filing bug 803276, go ahead and do the disabling on beta branch.
Attachment #672968 -
Flags: approval-mozilla-beta? → approval-mozilla-beta+
Comment 7•12 years ago
|
||
Please get this landed to beta asap so it's in our next Beta release.
Assignee | ||
Comment 8•12 years ago
|
||
http://hg.mozilla.org/releases/mozilla-beta/rev/8c6312b2da71
Updated•12 years ago
|
status-firefox17:
--- → fixed
Comment 9•12 years ago
|
||
We'll start tracking this for 18/19 if bug 803276 doesn't end up being the final solution.
Updated•12 years ago
|
Whiteboard: [js:t]
Assignee | ||
Updated•11 years ago
|
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•