803654 - Import mock into virtualenv

Status: RESOLVED FIXED

(Firefox Build System :: General, defect)

Description

[(not currently active) Ted Mielczarek]

I'd like to use the mock module for Python unittests. This patch imports mock-1.0.0 into the tree and puts it in the virtualenv.

Related: mock is apparently the core module "unittest.mock" in Python 3.3, which is neat. If we ever switch to requiring Python 3 we get this for free.

Comment 1

[(not currently active) Ted Mielczarek]

Attachment: Import mock into virtualenv

Comment 2

[Jeff Hammel]

Comment on attachment 673359 [details] [diff] [review]
Import mock into virtualenv

I didn't read the whole patch, but assuming this is just a straight copy of the canonical module and addition to virtualenv/packages, lgtm

Comment 3

[(not currently active) Ted Mielczarek]

That's exactly what it is. I untarred the 1.0.0 package from Pypi into the python/ dir, and updated build/virtualenv/packages.txt. (Sorry, should have mentioned that in my comment.)

Comment 4

[(not currently active) Ted Mielczarek]

https://hg.mozilla.org/integration/mozilla-inbound/rev/5981ff9d3f45

Comment 5

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/5981ff9d3f45

Comment 6

[:Benjamin Peterson]

It seems like a bit of generated junk like python/mock-1.0.0/html/.doctrees/*
was added. Intentional?

Comment 7

[(not currently active) Ted Mielczarek]

No, but if it's not hurting anything I'm not particularly worried about it.