803696 - [socorro-crashstats] Massive query strings in models to mware breaks json caching

Status: RESOLVED FIXED

(Socorro :: Webapp, task)

Description

[Peter Bengtsson [:peterbe]]

This causes trouble:
http://socorro/buginfo/bug?bug_ids=803125,801701,706432,797302,802355,801453,803262,766877,801336,791798,787879,801624,706432,802144,771407,803121,802476,801453,801394,803568,802037,803535,801516,787879,795826,802355,556643,801701,803125,798761,802798,785806,801453,801701,803125,801382,798778,802624,733323,787822,796188,801763,803194,801453,803018,801405,802144&include_fields=summary,status,id,resolution

Comment 1

[Peter Bengtsson [:peterbe]]

PR: https://github.com/mozilla/socorro-crashstats/pull/190

Comment 2

[[github robot]]

Commit pushed to master at https://github.com/mozilla/socorro-crashstats

https://github.com/mozilla/socorro-crashstats/commit/7a40efa8a051989b17dbaac7b707c0205c16a4d8
bug 803696 - models cache key not too long, r=rhelmer

Comment 3

[Stephen Donner [:stephend] Not actively reading bugmail]

Attachment: Post-fix screenshot

Comment 4

[Stephen Donner [:stephend] Not actively reading bugmail]

http://crash-stats-new-dev.allizom.org/buginfo/bug?bug_ids=803125,801701,706432,797302,802355,801453,803262,766877,801336,791798,787879,801624,706432,802144,771407,803121,802476,801453,801394,803568,802037,803535,801516,787879,795826,802355,556643,801701,803125,798761,802798,785806,801453,801701,803125,801382,798778,802624,733323,787822,796188,801763,803194,801453,803018,801405,802144&include_fields=summary,status,id,resolution:

[17:28:30.008] GET http://crash-stats-new-dev.allizom.org/buginfo/bug?bug_ids=803125,801701,706432,797302,802355,801453,803262,766877,801336,791798,787879,801624,706432,802144,771407,803121,802476,801453,801394,803568,802037,803535,801516,787879,795826,802355,556643,801701,803125,798761,802798,785806,801453,801701,803125,801382,798778,802624,733323,787822,796188,801763,803194,801453,803018,801405,802144&include_fields=summary,status,id,resolution [HTTP/1.1 200 OK 69ms]

Is that good enough to verify?

Comment 5

[Peter Bengtsson [:peterbe]]

I made this qa-. The JSON caching I was referring to is one that we only use for local development. 


FYI our middleware wrappers support two levels of caching. 

1. memcached

2. file based

What we often do in development is to switch memcache for a super volatile one called LocMemCache which is wiped as soon as you restart the local development server. But that's OK because then it falls back to the file based one. 

And the reason for having the file based on is to be able to manually fiddle (and fake) with what the middleware returns. So to try to simulate certain data all have to do is edit a .json file in the `models-cache` directory locally.