Closed
Bug 803724
Opened 12 years ago
Closed 12 years ago
[OS X] Text of some toolbar icons are not lined up
Categories
(Thunderbird :: Theme, defect)
Tracking
(thunderbird17 fixed, thunderbird18 fixed)
RESOLVED
FIXED
Thunderbird 19.0
People
(Reporter: Nomis101, Assigned: Paenglab)
References
Details
Attachments
(2 files, 2 obsolete files)
22.44 KB,
image/jpeg
|
Details | |
720 bytes,
patch
|
mconley
:
review+
standard8
:
approval-comm-aurora+
standard8
:
approval-comm-beta+
|
Details | Diff | Splinter Review |
In the monochrom toolbar on OS X, the text of some toolbar icons is a bit too far up. In the Screenshot its the button for Chat and File.
Assignee | ||
Comment 1•12 years ago
|
||
Make the rule less specific.
Assignee | ||
Comment 2•12 years ago
|
||
Better patch
Attachment #673548 -
Attachment is obsolete: true
Attachment #673548 -
Flags: review?(mconley)
Attachment #673549 -
Flags: review?(mconley)
Assignee | ||
Comment 3•12 years ago
|
||
Oops, previous patch was a wrong one. Now the correct patch, I promise.
Attachment #673549 -
Attachment is obsolete: true
Attachment #673549 -
Flags: review?(mconley)
Attachment #673550 -
Flags: review?(mconley)
Comment 4•12 years ago
|
||
Comment on attachment 673550 [details] [diff] [review] correct patch Review of attachment 673550 [details] [diff] [review]: ----------------------------------------------------------------- Looks good to me. Thanks Richard!
Attachment #673550 -
Flags: review?(mconley) → review+
Assignee | ||
Updated•12 years ago
|
Keywords: checkin-needed
Assignee | ||
Comment 5•12 years ago
|
||
Comment on attachment 673550 [details] [diff] [review] correct patch [Approval Request Comment] This is only a small CSS patch. With the now long cycles it would land on TB24 to the end user.
Attachment #673550 -
Flags: approval-comm-beta?
Attachment #673550 -
Flags: approval-comm-aurora?
Comment 6•12 years ago
|
||
https://hg.mozilla.org/comm-central/rev/5ba5d4c61642
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Flags: in-testsuite-
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 19.0
Updated•12 years ago
|
Attachment #673550 -
Flags: approval-comm-beta?
Attachment #673550 -
Flags: approval-comm-beta+
Attachment #673550 -
Flags: approval-comm-aurora?
Attachment #673550 -
Flags: approval-comm-aurora+
Comment 7•12 years ago
|
||
https://hg.mozilla.org/releases/comm-aurora/rev/310686c456d9 https://hg.mozilla.org/releases/comm-beta/rev/5ebfbccd7efb
status-thunderbird17:
--- → fixed
status-thunderbird18:
--- → fixed
You need to log in
before you can comment on or make changes to this bug.
Description
•