803733 - Remove the hack around otoro orientation issue when capturing still images

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia, defect)

Description

[Chris Jones [:cjones] inactive; ni?/f?/r? if you need me]

We should normalize all these device quirks at the platform level.  We've already busted another device from the hack.

Comment 1

[Michael Vines [:m1] [:evilmachines]]

Attachment: Normalize camera sensor orientation

Comment 2

[Michael Vines [:m1] [:evilmachines]]

PR for gaia portion: https://github.com/mozilla-b2g/gaia/pull/5909

Comment 3

[Michael Vines [:m1] [:evilmachines]]

Try run: https://tbpl.mozilla.org/?tree=Try&rev=dbf93f3bc829

Comment 4

[Michael Vines [:m1] [:evilmachines]]

Otoro/Unagi quirks already landed:
https://github.com/mozilla-b2g/android-device-otoro/commit/b456d081241f5c4bbf13d8f0e79ab140cc45a4f1
https://github.com/mozilla-b2g/android-device-unagi/commit/86e1911d940f1cfdad661603a305d07f3d041bb8

Comment 6

[Chris Jones [:cjones] inactive; ni?/f?/r? if you need me]

This blocks correctly-oriented photos on the commercial phone.

Comment 7

[Chris Jones [:cjones] inactive; ni?/f?/r? if you need me]

The PR of course looks fine, but please give us until Monday to land until we can work out something for otoro/unagi dogfooders.  Sorry about that.

Comment 8

[Michael Vines [:m1] [:evilmachines]]

Attachment: Trivial rebase

Carrying r+ forward

Comment 9

[Michael Vines [:m1] [:evilmachines]]

Comment on attachment 674898 [details] [diff] [review]
Trivial rebase

nm.  can't drive hg properly yet...

Comment 10

[Michael Vines [:m1] [:evilmachines]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/450f060c4577

Comment 11

[Chris Jones [:cjones] inactive; ni?/f?/r? if you need me]

Note to Moz dogfooders / bisecters: this patch and the associated gaia commit will result in rotated images being captured by the cameras on otoro and unagi.  That's 100% expected and understood.  You won't see this bug in full flashes.

mvines was kind enough to land that workaround for us.  However, we need to ship this workaround in a FOTA update to dogfooders.  (Or have them push a new file to device.)

Comment 12

[Ryan VanderMeulen [:RyanVM]]

I'll land this on Aurora after it lands on m-c. No need to request checkin on that part as long as it's got blocking-basecamp+ or approval-aurora+.

Comment 13

[Michael Vines [:m1] [:evilmachines]]

(In reply to Chris Jones [:cjones] [:warhammer] from comment #11)
> ... land that workaround for us.  

Ref:
https://github.com/mozilla-b2g/android-device-otoro/commit/b456d081241f5c4bbf13d8f0e79ab140cc45a4f1
https://github.com/mozilla-b2g/android-device-unagi/commit/86e1911d940f1cfdad661603a305d07f3d041bb8

Comment 14

[Chris Jones [:cjones] inactive; ni?/f?/r? if you need me]

Also FTR, the FOTA wheels are in motion.

Comment 15

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/450f060c4577

Comment 16

[Chris Jones [:cjones] inactive; ni?/f?/r? if you need me]

https://hg.mozilla.org/releases/mozilla-aurora/rev/ea122969082d

Comment 20

[Angela Hubenya]

Defect is verified as fixed using the Unagi device, build 20130114073222. 
Needs to be verified on an Otoro device.