803848 - Marketplace not respecting user's language set in preference and intl.accept_languages list

Status: RESOLVED FIXED

(Marketplace Graveyard :: General, defect)

Description

[Peter Pin-Guang Chen [:petercpg] (MozTW.org)]

Marketplace is always displayed in zh-CN while intl.accept_languages is set to "zh-tw, zh, en-us, en", with the language is set to English (US) in settings.

Languages could be switched correctly in account settings when intl.accept_languages was set to only "en-us, en".

Tested on latest Firefox desktop, fennec 19.0a1 nightly, and android 4.0 stock browser (all in zh-TW).

Comment 1

[Wil Clouser [:clouserw]]

Can you add a screenshot and a link?  You're seeing the marketplace in Chinese?  That shouldn't happen at all...

Comment 2

[Andy McKay]

I added in explicit lookup of some language codes, using shorter language codes:

https://github.com/mozilla/zamboni/blob/master/lib/settings_base.py#L126

That is being added, when it shouldn't be.

Setting that value to mkt/settings.py

SHORTER_LANGUAGES = {'en': 'en-US', 'pt': 'pt-PT'}

Should stop it doing that, when the relevant translations come in, we can add those back in.

Comment 3

[Andy McKay]

https://github.com/mozilla/zamboni/commit/a89bde