804698 - [socorro-crashstats] version passed to topchangers isn't correct

Status: VERIFIED FIXED

(Socorro :: Webapp, task)

Description

[Stephen Donner [:stephend] Not actively reading bugmail]

http://crash-stats-new-dev.allizom.org/topchangers/products/Firefox/versions/19.0a1 has links like so:

http://crash-stats-new-dev.allizom.org/report/list?range_value=7&range_unit=days&signature=js%3A%3Atypes%3A%3ATypeSet%3A%3Asweep%28JSCompartment*%29&version=Firefox

which yield:

version

    Select a valid choice. Firefox is not one of the available choices.

Comment 1

[Robert Helmer [:rhelmer]]

This harkens back to the early days of this code - this page still tries to work for single or multi-version selections.

This was done really inconsistently on the old app, so for the new one we decided to start with single-version-only and implement multi-version later, but this report didn't get the memo.

Comment 2

[Robert Helmer [:rhelmer]]

Hmmm so actually https://crash-stats-dev.allizom.org/products/Firefox/topchangers it has a special behavior if "Current Versions" is selected. On second thought, let's preserve this for the moment, in case anyone depends on it (since it's the default)

Comment 3

[Robert Helmer [:rhelmer]]

r? https://github.com/mozilla/socorro-crashstats/pull/244

Comment 4

[[github robot]]

Commits pushed to master at https://github.com/mozilla/socorro-crashstats

https://github.com/mozilla/socorro-crashstats/commit/2d08c843bec42fc229e35fc1ed8d9e3d76a0b10d
fixes bug 804698 - support multi-version for topchangers report, both in URL and outgoing links to /report/list

https://github.com/mozilla/socorro-crashstats/commit/79a3ed8428a2438af476701285f2134b586284e9
Merge pull request #244 from rhelmer/bug804698-topchangers-multi-version

fixes bug 804698 - support multi-version for topchangers report, both in...

Comment 5

[Stephen Donner [:stephend] Not actively reading bugmail]

Attachment: Post-fix screenshot

Comment 6

[Stephen Donner [:stephend] Not actively reading bugmail]

Verified FIXED on http://crash-stats-new-dev.allizom.org/topchangers/products/Firefox/versions/19.0a1