804955 - View button in Message security of Compose window does nothing when the address has no certificate

Status: RESOLVED FIXED

(MailNews Core :: Security: S/MIME, defect)

Description

[:aceman]

View button in Message security of Compose window does nothing when clicked on. The button is enabled but clicking it does nothing. It is probably because there is no certificate for the selected address.

I propose to disable the button in this case AND to change the label to "View..." as it opens a subdialog.

Comment 1

[:aceman]

Attachment: patch

Comment 2

[Magnus Melin [:mkmelin]]

There shouldn't be ellipsis for this just because it opens a new window. Ellipsis implies further action(s), but here it does all it should.

Comment 3

[Blake Winton (:bwinton) (:☕️)]

Comment on attachment 674737 [details] [diff] [review]
patch

(In reply to Magnus Melin from comment #2)
> There shouldn't be ellipsis for this just because it opens a new window.
> Ellipsis implies further action(s), but here it does all it should.

I agree.  It's like "About Thunderbird".

But, other than that, I like it.  ui-r=me with that changed back.  :)

Thanks,
Blake.

Comment 4

[:aceman]

Attachment: patch v2

Comment 5

[Magnus Melin [:mkmelin]]

Comment on attachment 676268 [details] [diff] [review]
patch v2

Review of attachment 676268 [details] [diff] [review]:
-----------------------------------------------------------------

Good fix, r=mkmelin

Comment 6

[:aceman]

Comment on attachment 676268 [details] [diff] [review]
patch v2

Technically the change is in mailnews so it will probably need a stamp from a mailnews peers.

Comment 7

[Kent James (:rkent)]

Comment on attachment 676268 [details] [diff] [review]
patch v2

I'll r+ this relying on mkmelin without testing myself.

Comment 8

[:aceman]

Yeah, thanks.

Comment 9

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/comm-central/rev/be89a8566060