804983 - WebTelephony API: DOM does not accurately handle an outgoing call

Status: RESOLVED FIXED

(Core :: DOM: Device Interfaces, defect)

Description

[Hsin-Yi Tsai (she/her) [:hsinyi]]

The DOM API does not accurately represent a call that wasn't placed through it. The DOM thinks whenever there's an unknown call, that should be incoming [1]. But that call could be placed by others (like STK call or by other process).

[1] http://mxr.mozilla.org/mozilla-central/source/dom/telephony/Telephony.cpp#405

Comment 1

[Mounir Lamouri (:mounir)]

How is STK placing the call if not trough the API?

Comment 2

[Hsin-Yi Tsai (she/her) [:hsinyi]]

(In reply to Mounir Lamouri (:mounir) from comment #1)
> How is STK placing the call if not trough the API?

Hi Mounir, 

The STK call is made through STK app by selecting stk menu, not through telephony API. The SIM makes the call according to the menu command. You may refer to Yoshi's comment here [1] for the behaviour of STK call. 

[1] https://bugzilla.mozilla.org/show_bug.cgi?id=804073#c9

Comment 3

[Hsin-Yi Tsai (she/her) [:hsinyi]]

bb? because this blocks bb+ Bug 802745

Comment 4

[Andrew Overholt [:overholt]]

Hsin-Yi, who will do this work?

Comment 5

[Hsin-Yi Tsai (she/her) [:hsinyi]]

Attachment: Patch

handled 'outgoing' call placed by others

Comment 6

[Ben Turner (not reading bugmail, use the needinfo flag!)]

Comment on attachment 676438 [details] [diff] [review]
Patch

Review of attachment 676438 [details] [diff] [review]:
-----------------------------------------------------------------

I can't see how this will add the outgoing call to the mCalls array or send the callschanged event.

Comment 7

[Ben Turner (not reading bugmail, use the needinfo flag!)]

Comment on attachment 676438 [details] [diff] [review]
Patch

Review of attachment 676438 [details] [diff] [review]:
-----------------------------------------------------------------

Oh, yes I can. Sorry, this looks good!

::: dom/telephony/Telephony.cpp
@@ +426,1 @@
>    return NS_OK;

Nit: Please add an extra line between the } and return.

Comment 8

[Hsin-Yi Tsai (she/her) [:hsinyi]]

(In reply to ben turner [:bent] from comment #7)
> Comment on attachment 676438 [details] [diff] [review]
> Patch
> 
> Review of attachment 676438 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> Oh, yes I can. Sorry, this looks good!
>
Great, thanks!
 
> ::: dom/telephony/Telephony.cpp
> @@ +426,1 @@
> >    return NS_OK;
> 
> Nit: Please add an extra line between the } and return.
OK~

Comment 9

[Hsin-Yi Tsai (she/her) [:hsinyi]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/7781dba5ed5e

Comment 10

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/7781dba5ed5e

Comment 11

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/e39dec4b812b