805189 - [video] typo in error message

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia, defect)

Description

[Fred Wenzel [:wenzel]]

Plug in the phone, open the video app.

Error message: "Video cannot be watch (sic) while plugged in".

Should be "... watched..."

Comment 1

[Martin de Keijzer[:Martin1982]]

Submitted a pull request on Github https://github.com/mozilla-b2g/gaia/pull/6023

Comment 2

[Martin de Keijzer[:Martin1982]]

Due to messing up with my (still) mediocore git skills I've opened a new pull request https://github.com/mozilla-b2g/gaia/pull/6061

Comment 3

[Martin de Keijzer[:Martin1982]]

Attachment: PR link with fix

Comment 4

[David Scravaglieri [:scravag]]

Framarz is getting info

Comment 5

[Josh Carpenter [:jcarpenter]]

Will be cleaned up in our pre-string freeze copy pass.

Comment 6

[Josh Carpenter [:jcarpenter]]

Actually strings for Video have already been frozen, IIRC. This was a typo that slipped past us. Stas, FYI. What's the protocol for submitting typo fixes post-string freeze?

Comment 7

[Staś Małolepszy :stas]

The protocol is outlined here: https://wiki.mozilla.org/L10n:B2G#Changing_strings_after_the_string-freeze

Here's my would-be review comment:  This being a typo, I prefer to just fix it in en-US, without notifying the localizers.  That's noise for them, I'm sure they figured out the correct translation.

So, please just land this in en-US without any changes to the identifier of the string.

Thanks!

Comment 8

[Staś Małolepszy :stas]

This landed in https://github.com/mozilla-b2g/gaia/pull/6061

Comment 9

[Rebecca Billings [:rbillings]]

It's unclear how to repro the problem as users are now able to play videos while the phone is plugged in. Tested on the 11/28 unagi build.

Comment 10

[amiller]

Device: Unagi
Build: 20121231070201
Does not repro.