Closed Bug 805206 Opened 12 years ago Closed 12 years ago

Social API keyboard-accessible menuitem is blank

Categories

(Firefox Graveyard :: SocialAPI, defect)

Product:
Firefox Graveyard
Component:
SocialAPI
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(firefox17 fixed, firefox18 fixed, firefox19 fixed)

Status:
RESOLVED FIXED
Milestone:
Firefox 19
Tracking Flags:
Tracking Status
firefox17 --- fixed
firefox18 --- fixed
firefox19 --- fixed

People

(Reporter: jaws, Assigned: jaws)

References

Details

(Whiteboard: [Fx17][qa-])

Attachments

(1 file, 1 obsolete file)

Patch v1.1
2.90 KB, patch
Felipe
: review+
lsblakk
: approval-mozilla-aurora+
lsblakk
: approval-mozilla-beta+
Details | Diff | Splinter Review
Attached patch Patch (obsolete) — — Splinter Review 
Bug 801040 tweaked the keyboard-accessible menu code, and removed the command. The command attribute did server a purpose though, as it set the label on the menuitem.
Attachment #674841 - Flags: review?(felipc)
Attachment #674841 - Flags: review?(felipc)
Attached patch Patch v1.1 — — Splinter Review 

        Attachment #674841 -
        Attachment is obsolete: true

        Attachment #674843 -
        Flags: review?(felipc)

        Attachment #674843 -
        Flags: review?(felipc) → review+

    
    

    
  
Comment on attachment 674843 [details] [diff] [review]
Patch v1.1

[Approval Request Comment]
Bug caused by (feature/regressing bug #): needed to fix a regression by bug 801040 (for social api)
User impact if declined: blank menuitem in tools menu
Testing completed (on m-c, etc.): locally and landed on m-c
Risk to taking this patch (and alternatives if risky): none expected
String or UUID changes made by this patch: none

        Attachment #674843 -
        Flags: approval-mozilla-beta?

        Attachment #674843 -
        Flags: approval-mozilla-aurora?

    
    

    
  
Backed out in https://hg.mozilla.org/integration/mozilla-inbound/rev/5bbfcd1d5296 - Impact when landed: 10 browser-chrome failures.

    
    

    
  
Oh, and my very favoritest sort of bustage: for historical reasons, Talos treats any run which has the string ERROR in allcaps in the log as a failure, and in Mac Talos other and dirtypaint you were triggering a whole lot of "Exception... "'ReferenceError: separator is not defined' when calling method: [nsIRunnable::run]"  nsresult: "0x8057001c (NS_ERROR_XPC_JS_THREW_JS_OBJECT)"

    
    

    
  
https://hg.mozilla.org/mozilla-central/rev/6a3dbca1ca7d
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Flags: in-testsuite-
Resolution: --- → FIXED
Target Milestone: --- → Firefox 19

    
    

    
  
Comment on attachment 674843 [details] [diff] [review]
Patch v1.1

Approving for uplift (even though untracked) since it's needed for the Social API launch in 17.

        Attachment #674843 -
        Flags: approval-mozilla-beta?

        Attachment #674843 -
        Flags: approval-mozilla-beta+

        Attachment #674843 -
        Flags: approval-mozilla-aurora?

        Attachment #674843 -
        Flags: approval-mozilla-aurora+

    
    

    
  
Does this fix need any QA?

    
    

    
  
(In reply to Anthony Hughes, Mozilla QA (:ashughes) from comment #10)
> Does this fix need any QA?

We should be all set here.
Whiteboard: [Fx17] → [Fx17][qa-]

    
  
Product: Firefox → Firefox Graveyard

          You need to log in
          before you can comment on or make changes to this bug.
        






  

    
  







  

    

      
Attachment

      

      
      
      
      
    

    

      

        

          

            
General

            

              Creator: 



            

            
Created: 

            
Updated: 

            
Size: