80543 - nsOutlinerBoxObject::RowCountChanged can behave incorrectly

Status: RESOLVED FIXED

(Core :: XUL, defect)

Description

[Brian Ryner (not reading)]

Calling rowCountChanged when you are removing rows and are not scrolled to the
top of the outliner can cause it to miscompute mTopRowIndex, which causes it to
ask the outliner view for the wrong row indices (which causes a totally
incorrect display).

Comment 1

[Brian Ryner (not reading)]

Attachment: patch

Comment 2

[Brian Ryner (not reading)]

Attachment: oops, I really wanted PR_MAX

Comment 3

[sairuh (rarely reading bugmail)]

bryner, is this the bug where i got the wacky highlighting after double-clicking
a dir which had fewer contents than its parent?

Comment 4

[Brian Ryner (not reading)]

sairuh -- Yep, this is the root cause of the problem.

Comment 5

[David Hyatt]

sr=hyatt

Comment 6

[(not reading, please use [e-mail] instead)]

r=sspitzer

Comment 7

[Brian Ryner (not reading)]

fix checked in.

Comment 8

[R.K.Aa.]

I just built on Linux and now crash trying to wheelscroll in filepicker OR after
having selected a file and then wheelscrolling. Twice in a row in

nsCacheEntryHashTable::GetKey () from dist/bin/components/libnkcache.so

Using RH's gcc2.96-81 so perhaps not all see this but thought it worth mentioning.

Comment 9

[R.K.Aa.]

Sorry. The crash is unrelated. (it's all over the place here - editing AB card,
opening in new window - even closing one.)