805769 - Unify the weak maps for pause and thread-lifetime actors

Status: NEW

(DevTools :: Debugger, task, P5)

Description

[Panos Astithas (he/him) [:past] (please ni?)]

Now that upgrading a pause-lifetime actor to a thread-lifetime one does not alter its ID, we can unify the weak maps we use to retrieve the actors.

Comment 1

[Panos Astithas (he/him) [:past] (please ni?)]

Attachment: Patch v1

WIP. Breaks a few tests.

Comment 2

[Panos Astithas (he/him) [:past] (please ni?)]

I no longer have the time to work on this.

Comment 3

[Jason Laster [:jlast]]

Logan this looks like a nice win, what do you think?

Comment 4

[Jason Laster [:jlast]]

the code has shifted, but this still looks relevant. 
https://searchfox.org/mozilla-central/source/devtools/server/actors/thread.js

Comment 5

[Alexandre Poirot [:ochameau]]

TBH, I don't really know this precise code.

But generally, note that manually managed ActorPool might be simplified if we convert the actor to protocol.js Actor.
Actor are pools and you can register the child actors to the base actor, if the child actor lifetime is the same than the base actor. Otherwise, you still need a dedicated ActorPool, so that you can destroy the pool individually and keep the base actor alive.

Comment 6

[Logan Smyth [:loganfsmyth]]

Also not that familiar, but this does seem reasonable from what I've seen.