80577 - Order of words reversed in Hebrew site on Mac

Status: RESOLVED FIXED

(Core :: Layout: Text and Fonts, defect)

Description

[Simon Montagu :smontagu]

I was sent the attached screen shots by [e-mail]

Each word is displayed correctly, but the order of the words is reversed. 
For example the Hebrew equivalent of WHAT'S NEW, which should be rendered 

WEN S'TAHW

is rendered

S'TAHW WEN

Comment 1

[Simon Montagu :smontagu]

Attachment: screenshot from www.walla.co.il

Comment 2

[Simon Montagu :smontagu]

Attachment: screenshot from www.msn.co.il

Comment 3

[Simon Montagu :smontagu]

The first thing to try in fixing this is to port the IBMBIDI changes in 
gfx/src/windows/nsRenderingContextWin.cpp to 
gfx/src/mac/nsRenderingContextMac.cpp

Comment 4

[Frank Tang]

simon- Please attach nwe screen shot in GIF or JPEG. I somehow cannot view tiff. 
Also, could you attach the CORRECT screen shot here so I can compare if I write 
some new code. 
reassing to ftang

Comment 5

[Frank Tang]

mark it as assigned

Comment 6

[Simon Montagu :smontagu]

Attaching new screenshots. For testing I suggest you use the Hebrew testpage 
that Mimi prepared for Andreas, which has text in Hebrew with images of the 
expected rendering.

Comment 7

[Simon Montagu :smontagu]

Attachment: screenshot of www.walla.co.il (gif)

Comment 8

[Simon Montagu :smontagu]

Attachment: screenshot of msn.co.il (gif)

Comment 9

[Simon Montagu :smontagu]

Attachment: expected results at www.walla.co.il

Comment 10

[Frank Tang]

I am confsued. Which screen shots are right, which are wrong ?

Comment 11

[Simon Montagu :smontagu]

WRONG:
  attachment 34529 [details] -- walla
  attachment 34530 [details] -- msn

RIGHT:
  attachment 34531 [details] -- walla

I didn't attach a RIGHT screenshot of www.msn.co.il, because the content of the 
site keeps changing.

Comment 12

[Frank Tang]

no time to work on mac arabic/hewbrew . move to future.

Comment 13

[Andreas Becker]

Changing QA contact to [e-mail].

Changing component to "Bidi..." and adding intl keyword.

Comment 14

[timeless]

*** Bug 94633 has been marked as a duplicate of this bug. ***

Comment 15

[timeless]

*** Bug 93665 has been marked as a duplicate of this bug. ***

Comment 16

[timeless]

*** Bug 81943 has been marked as a duplicate of this bug. ***

Comment 17

[timeless]

*** Bug 81020 has been marked as a duplicate of this bug. ***

Comment 18

[timeless]

From dupe:
------- Additional Comments From Simon Montagu 2001-05-18 11:52 -------
What I was trying to say was that the Hebrew in your screenshot has been
ordered with base direction left-to-right instead of right-to-left. In
Windows when mRightToLeftText is true in nsRenderingContextWin.cpp we call
SetTextAlign with TA_RTLREADING, which sets the base direction for the
device context's native reordering to right-to-left. You have to find the
equivalent API for Mac and call it.
------- Additional Comments From Simon Montagu 2001-05-21 15:51 -------
What I meant was the base (paragraph) direction used when the platform invokes 
its own implementation of the Bidi algorithm. This is important, because it 
determines whether a logical text like

COPYRIGHT 2000 MICROSOFT

is rendered

TGHIRYPOC 2000 TFOSORCIM   <--- with LTR base direction

or

TFOSORCIM 2000 THGIRYPOC   <--- with RTL base direction

In Windows this is set by calling SetTextAlign with the flag TA_RTLREADING (by 
the way the comment in the source of nsRenderingContextWin.cpp is not 
synchronized with the code -- I'll file a separate bug on that).

Comment 19

[timeless]

*** Bug 96305 has been marked as a duplicate of this bug. ***

Comment 20

[Zach Lipton [:zach]]

Mass-move all BiDi Hebrew and Arabic qa to me, [e-mail]. 
Thank you Gilad for your service to this component, and best of luck to you 
in the future.

Sholom. 

Comment 21

[Greg K.]

*** Bug 108331 has been marked as a duplicate of this bug. ***

Comment 22

[Shoshannah Forbes]

On system 10, I see this in some places but not others. not sure if this is 
the same bug? adding attachment

Comment 23

[Shoshannah Forbes]

Attachment: Tapuz (logical) web sites on OS X. notice the order of the words where the arrows point

Comment 24

[Frank Tang]

probably could be fixed by bug 116976 and bug 116982

Comment 25

[Frank Tang]

I believe the following three patch should fix most mac os hewbrew problem

big endian issue in nsFrame.cpp
see latest patch in http://bugzilla.mozilla.org/show_bug.cgi?id=116976

big endian issue in nsBidiImp.cpp 
http://bugzilla.mozilla.org/attachment.cgi?id=62917&action=view

turn off hebrew reordering and do not report hint on mac gfx
http://bugzilla.mozilla.org/attachment.cgi?id=62920&action=view

Comment 26

[Frank Tang]

this should be fixed right now. If you see some speical case which are not
right. Please file seperate bug for the speical case and assign to smontagu first.