Closed
Bug 805789
Opened 12 years ago
Closed 12 years ago
Handle null and undefined as correct values instead of converted to strings on USSDReceivedEventDict::message
Categories
(Core :: DOM: Device Interfaces, defect)
Core
DOM: Device Interfaces
Tracking
()
RESOLVED
FIXED
mozilla19
People
(Reporter: willyaranda, Assigned: willyaranda)
References
Details
Attachments
(1 file)
382 bytes,
patch
|
smaug
:
review+
bajaj
:
approval-mozilla-aurora+
|
Details | Diff | Splinter Review |
Should be: DOMString ? message = null;
Updated•12 years ago
|
Assignee | ||
Comment 1•12 years ago
|
||
Handle null and undefined as correct values and not convert them to string.
Attachment #675539 -
Flags: review?(bugs)
Updated•12 years ago
|
Attachment #675539 -
Flags: review?(bugs) → review+
Assignee | ||
Comment 3•12 years ago
|
||
Comment on attachment 675539 [details] [diff] [review] Patch [Approval Request Comment] Bug caused by (feature/regressing bug #): Followup bug 794011 User impact if declined: We need more checks in our USSD UI (need to check against strings like "undefined" and "null" instead of object null and undefined). Testing completed (on m-c, etc.): m-i Risk to taking this patch (and alternatives if risky): None String or UUID changes made by this patch: None
Attachment #675539 -
Flags: approval-mozilla-aurora?
Updated•12 years ago
|
Attachment #675539 -
Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
Comment 4•12 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/a38917528484
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla19
Comment 5•12 years ago
|
||
https://hg.mozilla.org/releases/mozilla-aurora/rev/c883d02a0bd9
status-firefox18:
--- → fixed
status-firefox19:
--- → fixed
You need to log in
before you can comment on or make changes to this bug.
Description
•