Closed
Bug 805790
Opened 12 years ago
Closed 12 years ago
some util.command fixes
Categories
(Release Engineering :: General, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: rail, Assigned: rail)
Details
Attachments
(1 file)
|
3.59 KB,
patch
|
bhearsum
:
review+
rail
:
checked-in+
|
Details | Diff | Splinter Review |
* copy kwargs before modifying it * use subprocess.list2cmdline instead of escape * PEP8
Attachment #675535 -
Flags: review?(bhearsum)
|
||
Comment 1•12 years ago
|
||
Comment on attachment 675535 [details] [diff] [review] util.commands fixes Review of attachment 675535 [details] [diff] [review]: ----------------------------------------------------------------- list2cmdline isn't technically a public method, but docstring in http://svn.python.org/projects/python/trunk/Lib/subprocess.py makes it seem like it's pretty safe to rely on.
Attachment #675535 -
Flags: review?(bhearsum) → review+
|
Assignee | |
Comment 2•12 years ago
|
||
Comment on attachment 675535 [details] [diff] [review] util.commands fixes http://hg.mozilla.org/build/tools/rev/c8d8f3dd662e
Attachment #675535 -
Flags: checked-in+
|
|
Assignee | |
Updated•12 years ago
|
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
|
||
Updated•11 years ago
|
Product: mozilla.org → Release Engineering
|
|
||
Updated•6 years ago
|
Component: General Automation → General
You need to log in
before you can comment on or make changes to this bug.
Description
•