805826 - Change Box.com serviceURL to point to 25GB promotional page

Status: RESOLVED FIXED

(Thunderbird :: FileLink, defect)

Description

[Mike Conley (:mconley) (:⚙️)]

For Box.com Filelinks, we'd like the icon and link to Box to take users to the 25GB promotional page.

Comment 1

[Mike Conley (:mconley) (:⚙️)]

Brian - do you think you could give this a shot? Trivial fix - basically, just update the serviceURL for nsBox.js to point to https://www.box.com/thunderbird

I can review that for you lickity split.

Comment 2

[Brian King [:kinger]]

Attachment: Fix

No problem, for review...

Comment 3

[Mike Conley (:mconley) (:⚙️)]

Comment on attachment 675855 [details] [diff] [review]
Fix

[Approval Request Comment]
Regression caused by (bug #): 
User impact if declined: 
Testing completed (on c-c, etc.): 
Risk to taking this patch (and alternatives if risky):

Comment 4

[Mike Conley (:mconley) (:⚙️)]

Very not risky for Aurora and Beta.

Comment 5

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/comm-central/rev/a03c8b87763e

Thanks for the patch, Brian! One request - to make life easier for those checking in on your behalf, please make sure that hg is configured per the below page so that your future patches have all the needed metadata for checkin. Thanks!
https://developer.mozilla.org/en-US/docs/Creating_a_patch_that_can_be_checked_in

Comment 6

[Mark Banner (:standard8)]

https://hg.mozilla.org/releases/comm-aurora/rev/bf2fbd2a73fe
https://hg.mozilla.org/releases/comm-beta/rev/19b365756386