805862 - Determine what broke the Windows PGO builds without --enable-profiling

Status: RESOLVED FIXED

(Core :: JavaScript Engine, defect)

Description

[(no longer active)]

The regression range is here: https://tbpl.mozilla.org/?tree=Profiling&rev=9835584f5fdd

Comment 1

[Ed Morley [:emorley]]

293bdc2afe11:
https://tbpl.mozilla.org/?tree=Try&rev=2c9b350c6c2f

b011b2c888d1:
https://tbpl.mozilla.org/?tree=Try&rev=db5b31752a62

05e44f47d1bf:
https://tbpl.mozilla.org/?tree=Try&rev=982c5c49b42a

Comment 2

[Ed Morley [:emorley]]

New range:
https://hg.mozilla.org/projects/profiling/pushloghtml?fromchange=05e44f47d1bf&tochange=9835584f5fdd

54591f4e0f79:
https://tbpl.mozilla.org/?tree=Try&rev=28f7e9b60ded

8a6b6b5f3e55:
https://tbpl.mozilla.org/?tree=Try&rev=1c86131db1d1

79154a91fb15:
https://tbpl.mozilla.org/?tree=Try&rev=f936273adce3

Comment 3

[Ed Morley [:emorley]]

Updated regression range:
https://hg.mozilla.org/projects/profiling/pushloghtml?fromchange=79154a91fb15&tochange=9835584f5fdd

04602cf8bff7:
https://tbpl.mozilla.org/?tree=Try&rev=3be98ec191b0

Comment 4

[Ed Morley [:emorley]]

Reduced range: (not that hgweb can display it properly :-/)
https://hg.mozilla.org/projects/profiling/pushloghtml?fromchange=79154a91fb15&tochange=04602cf8bff7

Caused by one of:
https://hg.mozilla.org/projects/profiling/rev/e1c7f5195704
https://hg.mozilla.org/projects/profiling/rev/df8e5da6e69f
https://hg.mozilla.org/projects/profiling/rev/04602cf8bff7

Comment 5

[Ed Morley [:emorley]]

(Bah hit submit too soon)

So going to blame bug 787703.

Comment 6

[(no longer active)]

I'll back it out, thanks a lot for your investigation.

Note that we need to track this as it means busted Windows PGO builds when we uplift 19 to Aurora.

Comment 7

[(no longer active)]

Hmm, except that patch could not be backed out cleanly.  Jason, would you mind backing it out as soon as possible, please?  We're not getting any PGO testing on Windows on non-profiling builds (which will become Aurora) because of this bug.  Thanks!

Comment 8

[Phil Ringnalda (:philor)]

And we were a little late, since he landed it on Aurora (with the bustage you would expect) at 16:18, 90 minutes before comment 4.

Comment 9

[Jason Orendorff [:jorendorff]]

Let's discuss in bug 787703.

Comment 10

[(no longer active)]

Fixed by backout: https://hg.mozilla.org/integration/mozilla-inbound/rev/df94ebb4b929