Closed
Bug 806011
Opened 12 years ago
Closed 8 years ago
Can't change the character set for opened saved message
Categories
(Thunderbird :: Message Reader UI, defect)
Tracking
(thunderbird44 wontfix, thunderbird45 fixed, thunderbird46 fixed, thunderbird47 fixed)
RESOLVED
FIXED
Thunderbird 47.0
People
(Reporter: dma_k, Assigned: jorgk-bmo)
References
Details
Attachments
(3 files)
1.13 KB,
application/octet-stream
|
Details | |
28.38 KB,
image/png
|
Details | |
1.16 KB,
patch
|
mkmelin
:
review+
jorgk-bmo
:
approval-comm-aurora+
rkent
:
approval-comm-beta+
|
Details | Diff | Splinter Review |
User Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:15.0) Gecko/20100101 Firefox/15.0 Build ID: 20120824154833 Steps to reproduce: * Open the attached test.eml using "File → Open Saved Message"... * Having the "View → Character Encoding → Auto-Detect" set to "Russian", the given message is not correctly recognized as UTF-8 message. * Setting "Character Encoding" to "Unicode (UTF-8)" has no effect. Expected: It is not possible to force the correct encoding to view the massage.
Assignee | ||
Updated•8 years ago
|
Status: UNCONFIRMED → NEW
Ever confirmed: true
Comment 4•8 years ago
|
||
nsMessenger::SetDocumentCharset - http://mxr.mozilla.org/comm-central/source/mailnews/base/src/nsMessenger.cpp#1596
Assignee | ||
Comment 5•8 years ago
|
||
Looking at it in the debugger shows that at https://dxr.mozilla.org/comm-central/source/mailnews/base/src/nsMessenger.cpp#1600 mLastDisplayURI is empty, to the block that follows is skipped and the message is not displayed again using the override charset. Note, that forwarding/replying does use the override. mLastDisplayURI is only set once here in nsMessenger::OpenURL(): https://dxr.mozilla.org/comm-central/source/mailnews/base/src/nsMessenger.cpp#445 Also note the comment here: https://dxr.mozilla.org/comm-central/source/mailnews/base/src/nsMessenger.h#90 Messages opened from files are treated in nsMessenger::LoadURL(). Setting mLastDisplayURI there fixes the problem. Patch coming.
Assignee | ||
Comment 6•8 years ago
|
||
One-line fix as discussed in comment #5.
Attachment #8713865 -
Flags: review?(mkmelin+mozilla)
Comment 7•8 years ago
|
||
Comment on attachment 8713865 [details] [diff] [review] Suggested solution (v1). Review of attachment 8713865 [details] [diff] [review]: ----------------------------------------------------------------- Yes, this seems reasonable and works fine! r=mkmelin
Attachment #8713865 -
Flags: review?(mkmelin+mozilla) → review+
Updated•8 years ago
|
Assignee: nobody → mozilla
Status: NEW → ASSIGNED
Assignee | ||
Updated•8 years ago
|
Keywords: checkin-needed
Assignee | ||
Comment 8•8 years ago
|
||
Comment on attachment 8713865 [details] [diff] [review] Suggested solution (v1). [Approval Request Comment] Regression caused by (bug #): No regression. User impact if declined: Low, can't change charset of message opened from file. Testing completed (on c-c, etc.): Manual. Risk to taking this patch (and alternatives if risky): Not risky, one line change to set the message URL.
Attachment #8713865 -
Flags: approval-comm-beta?
Attachment #8713865 -
Flags: approval-comm-aurora+
https://hg.mozilla.org/comm-central/rev/f98bae5d9f43
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 47.0
Assignee | ||
Comment 10•8 years ago
|
||
Aurora (TB 46): https://hg.mozilla.org/releases/comm-aurora/rev/d61d865c805e
status-thunderbird44:
--- → wontfix
status-thunderbird45:
--- → affected
status-thunderbird46:
--- → fixed
status-thunderbird47:
--- → fixed
Comment 11•8 years ago
|
||
Comment on attachment 8713865 [details] [diff] [review] Suggested solution (v1). http://hg.mozilla.org/releases/comm-beta/rev/18da5ccc17b1
Attachment #8713865 -
Flags: approval-comm-beta? → approval-comm-beta+
Updated•8 years ago
|
You need to log in
before you can comment on or make changes to this bug.
Description
•