806100 - datazilla ts results have more data than they should

Status: RESOLVED FIXED

(Testing :: Talos, defect)

Description

[Jeff Hammel]

From:

talos -n -d -a ts --develop -e `which firefox` --datazilla-url
foo.json --cycles 5

I get

"""
    "results": {
      "ts": [
        494.0, 
        494.0, 
        420.0, 
        494.0, 
        420.0, 
        438.0, 
        494.0, 
        420.0, 
        438.0, 
        422.0, 
        494.0, 
        420.0, 
        438.0, 
        422.0, 
        441.0
      ]
"""

This should be just 494.0, 420.0, 438.0, 422.0, 441.0 .  We are
wrongly extending vs appending somewhere.

Comment 1

[Joel Maher ( :jmaher ) (UTC -8)]

Attachment: fix datazilla ts tests (1.0)

fix datazilla ts test output.  We might want to extend this to more stuff as well.

Also found a bug in terminate process and I needed to fix this in order to test this.

Comment 2

[Jeff Hammel]

Comment on attachment 675858 [details] [diff] [review]
fix datazilla ts tests (1.0)

ABICT, this is a misindentation in the original file.  I'll post a possible fix

Comment 3

[Jeff Hammel]

Attachment: fix indentation level

Comment 4

[Joel Maher ( :jmaher ) (UTC -8)]

Comment on attachment 675866 [details] [diff] [review]
fix indentation level

Review of attachment 675866 [details] [diff] [review]:
-----------------------------------------------------------------

ahh!

Comment 5

[Geoff Brown [:gbrown] (pto Apr 11-18)]

There was an Android ts improvement of about 8% around Oct 18, which seemed to correspond to a talos.zip update -- might this bug account for that?

Comment 6

[Joel Maher ( :jmaher ) (UTC -8)]

yeah, there is a good chance.

Comment 7

[Jeff Hammel]

ABICT, this comes from this changeset: http://hg.mozilla.org/build/talos/rev/e3ab367914e6 .  Of course this doesn't tell when a talos.zip was deployed, but Oct 18 seems a bit out.

Comment 8

[Joel Maher ( :jmaher ) (UTC -8)]

http://hg.mozilla.org/build/talos/rev/c1c4733d4629