Closed
Bug 8062
Opened 25 years ago
Closed 25 years ago
[PP] GTK Menus not displaying if menubar not displayed immediatly
Categories
(Core :: XUL, defect, P3)
Tracking
()
M8
People
(Reporter: mcafee, Assigned: pavlov)
Details
(Whiteboard: The current code works... but this should be fixed. I'm looking into it. Not really needed for M7)
Menus are not displaying. erik@netscape.com is also seeing this: > I tried changing the smoketest URL in navigator.xul to about:blank, but > the menus were still blank, so it doesn't smell like that infamous bug > to me... > > I believe this new bug was introduced between Thursday and Saturday. Or, > if it's not a new bug, it's a new behavior or manifestation of the same > bug.
Reporter | ||
Updated•25 years ago
|
Summary: Gtk: Menus are not displaying → [Regression] Gtk: Menus are not displaying
Reporter | ||
Comment 1•25 years ago
|
||
Possible dup of 7417, but the about:blank workaround is apparently not working either, so .. new bug I think.
Reporter | ||
Updated•25 years ago
|
Assignee: chofmann → pavlov
Reporter | ||
Comment 2•25 years ago
|
||
http://cvs-mirror.mozilla.org/webtools/bonsai/showcheckins.cgi?person=pavlov%25pavlov.net&treeid=SeaMonkey Pavlov checked in some menu changes, I smell a rat.
Reporter | ||
Updated•25 years ago
|
Target Milestone: M7
Reporter | ||
Updated•25 years ago
|
Component: other → XP Toolkit/Widgets
Reporter | ||
Updated•25 years ago
|
Status: NEW → RESOLVED
Closed: 25 years ago
Resolution: --- → FIXED
Reporter | ||
Comment 3•25 years ago
|
||
one-line backout of pavlov's change to nsMenuBar.cpp fixes this. Fixed.
so could someone explain why this worked for me? assuming (yaeh i know, bad..) nsWindow::ShowMenuBar() is being called, there should be no problem. the call to gtk_widget_show(menubar) in nsMenuBar::Create is a bad thing(tm) and shouldn't be there. I will look at this code again tonight.
Updated•25 years ago
|
Status: RESOLVED → REOPENED
Comment 5•25 years ago
|
||
pavlov: I did some testing of your code without the extra call to gtk_widget_show. nsWindow::ShowMenuBar() is definitely being called, and it is calling gtk_widget_show(menubar). It's not working right though. The actual menu BAR is being displayed (as in the gray area at the top of the window), but no actual menus are appearing. This is with gtk+ 1.2.1.
Status: REOPENED → ASSIGNED
Summary: [Regression] Gtk: Menus are not displaying → [PP] GTK Menus not displaying if menubar not displayed immediatly
Target Milestone: M7 → M8
hmm, ok. i'm using 1.2.3 and its working fine. mcafee, what version of gtk are you using?
Comment 7•25 years ago
|
||
I'm not seeing any menubars in the browser (they're fine in the editor) in my morning 6/14 build.
Reporter | ||
Comment 8•25 years ago
|
||
I'm pretty close to the gtk tip.
Reporter | ||
Updated•25 years ago
|
Target Milestone: M8 → M7
Reporter | ||
Comment 9•25 years ago
|
||
M7.
Comment 10•25 years ago
|
||
I'm going to upgrade my Glib/Gtk+ and see if there's any change. I'm building with client.mk, and no additional options. NSPR built from the tip. Pavlov: are you using a similar configuration?
Comment 11•25 years ago
|
||
I can't tell anything one way or the other on this bug because of symptoms of 7417. I'm seeing some things that I don't remember seeing before, like garbage in the content window before the page is rendered, and at one point the page rendered in the sidebar.
Whiteboard: The current code works... but this should be fixed. I'm looking into it. Not really needed for M7
Updated•25 years ago
|
Target Milestone: M7 → M8
Comment 12•25 years ago
|
||
moving to m8
Assignee | ||
Updated•25 years ago
|
Status: ASSIGNED → RESOLVED
Closed: 25 years ago → 25 years ago
Resolution: --- → DUPLICATE
Assignee | ||
Comment 13•25 years ago
|
||
dup of 7147 *** This bug has been marked as a duplicate of 7147 ***
Updated•25 years ago
|
Status: RESOLVED → VERIFIED
Comment 14•25 years ago
|
||
I believe pavlov means Dup of Bug 7417 (not 7147)... and i'm just verifying this as a dup of that bug.
Assignee | ||
Comment 15•25 years ago
|
||
your right. wrong bug number as duplicate
You need to log in
before you can comment on or make changes to this bug.
Description
•