806283 - Include native iterators in "object/misc" memory reports.

Status: RESOLVED FIXED

(Core :: JavaScript Engine, defect)

Description

[Nicholas Nethercote [inactive]]

We don't measure NativeIterator objects pointed to by the private slot of
PropertyIteratorObjects.

Comment 1

[Nicholas Nethercote [inactive]]

Attachment: Include native iterators in "object/misc" memory reports.

This patch typically measures a few 100 KBs of NativeIterator objects, esp. in
B2G profiles.

Comment 2

[Justin Lebar (not reading bugmail)]

Do we want to split these out, so we have more visibility into where our memory is going?

Comment 3

[Nicholas Nethercote [inactive]]

Attachment: Split up and add native iterators to "object/misc" memory reports.

This revised patch: 

- Splits up the "objects/misc" entry into three parts: "arguments-data",
  "regexp-statics", and "property-iterator-data".  
  
- Renames the "objects" sub-path as "objects-extra", to match "shapes-extra"
  (and better distinguish it from the "gc-heap/objects/*" reports).

Comment 4

[Nicholas Nethercote [inactive]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/2f8306353ae9

Comment 5

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/2f8306353ae9

Comment 6

[Nicholas Nethercote [inactive]]

Comment on attachment 676402 [details] [diff] [review]
Split up and add native iterators to "object/misc" memory reports.

[Approval Request Comment]

Bug caused by (feature/regressing bug #):  N/A

User impact if declined: less insight into memory consumption for B2G.

Testing completed (on m-c, etc.): landed on m-c today.

Risk to taking this patch (and alternatives if risky): negligible;  code only runs when about:memory is loaded or a memory report is triggered. 

String or UUID changes made by this patch: none.

Comment 7

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/c0dfb00e3030

This required a bit of unbitrotting to apply to Aurora, but it was pretty mechanical. Probably wouldn't hurt to look it over as a sanity check, though.

Comment 8

[Nicholas Nethercote [inactive]]

Probably wouldn't hurt to look it over as a sanity check, though.

> Looks ok to me.  Thanks for uplifting it.