Closed
Bug 806600
Opened 12 years ago
Closed 12 years ago
Faster tests, no need to bcrypt in integration tests
Categories
(Webtools Graveyard :: Elmo, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
2.4
People
(Reporter: peterbe, Assigned: peterbe)
Details
Attachments
(1 file)
324 bytes,
patch
|
Pike
:
review+
|
Details | Diff | Splinter Review |
With bcrypt as the hasher storing our users' passwords: Ran 170 tests in 27.822s With MD5...: Ran 170 tests in 14.478s I ran some profiling on the test suite and django_sha2's hasher.py is the most guilty one. We don't need secure passwords in tests. Besides, we don't really care much about passwords because our real users are stored with unusable passwords anyway (using LDAP instead)
Assignee | ||
Comment 1•12 years ago
|
||
I'm applying this same technique on all my other projects.
Attachment #676367 -
Flags: review?(l10n)
Assignee | ||
Comment 2•12 years ago
|
||
An alternative is to leave in settings/local.py-dist, but commented out, this setting so individual developers who are confident with what they do can switch this on for faster tests. 30 seconds it's much to wait for for jenkins.
Comment 3•12 years ago
|
||
Comment on attachment 676367 [details] [diff] [review] works wonderfully Review of attachment 676367 [details] [diff] [review]: ----------------------------------------------------------------- Looks good to me, r=me.
Attachment #676367 -
Flags: review?(l10n) → review+
Comment 4•12 years ago
|
||
Commit pushed to develop at https://github.com/mozilla/elmo https://github.com/mozilla/elmo/commit/c4e24bd7c77c7c236556fb041f1fe954364f51bd bug 806600 - faster tests with md5 hasher, r=Pike
Assignee | ||
Updated•12 years ago
|
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Updated•12 years ago
|
Target Milestone: --- → 2.4
Updated•12 years ago
|
Assignee: nobody → peterbe
Updated•4 years ago
|
Product: Webtools → Webtools Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•