Closed
Bug 806687
Opened 12 years ago
Closed 12 years ago
Port browser_privatebrowsing_localStorage.js to the new per-window PB APIs
Categories
(Firefox :: Private Browsing, defect)
Tracking
()
RESOLVED
FIXED
Firefox 19
People
(Reporter: ehsan.akhgari, Assigned: bellindira)
References
(Blocks 1 open bug)
Details
Attachments
(1 file)
5.64 KB,
patch
|
ehsan.akhgari
:
review+
|
Details | Diff | Splinter Review |
http://mxr.mozilla.org/mozilla-central/source/browser/components/privatebrowsing/test/browser/global/browser_privatebrowsing_localStorage.js In order to port this test, the file needs to be copied to the perwindow/ directory, and then instead of setting privateBrowsingEnabled, we need to open a new private browsing window and then run the test on that window.
Updated•12 years ago
|
Assignee: nobody → bellindira
Assignee | ||
Updated•12 years ago
|
Status: NEW → ASSIGNED
Assignee | ||
Comment 1•12 years ago
|
||
executeSoon on checkLocalStorage is required to make it work well.
Attachment #680676 -
Flags: review?(ehsan)
Reporter | ||
Comment 2•12 years ago
|
||
Comment on attachment 680676 [details] [diff] [review] Added Test Case per window Review of attachment 680676 [details] [diff] [review]: ----------------------------------------------------------------- Looks good!
Attachment #680676 -
Flags: review?(ehsan) → review+
Reporter | ||
Comment 3•12 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/b431265004e5
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 19
You need to log in
before you can comment on or make changes to this bug.
Description
•