Closed
Bug 806688
Opened 12 years ago
Closed 12 years ago
Port browser_privatebrowsing_localStorage_before_after.js to the new per-window PB APIs
Categories
(Firefox :: Private Browsing, defect)
Tracking
()
RESOLVED
FIXED
Firefox 20
People
(Reporter: ehsan.akhgari, Assigned: marioalv)
References
(Blocks 1 open bug)
Details
Attachments
(1 file, 1 obsolete file)
6.96 KB,
patch
|
ehsan.akhgari
:
review+
|
Details | Diff | Splinter Review |
http://mxr.mozilla.org/mozilla-central/source/browser/components/privatebrowsing/test/browser/global/browser_privatebrowsing_localStorage_before_after.js In order to port this test, the file needs to be copied to the perwindow/ directory, and then instead of setting privateBrowsingEnabled, we need to open a new private browsing window and then run the test on that window. Note that the per-window version of this test can have both the private and non-private window simultaneously open as opposed to the current way that the test is structured. Specifically it should avoid setting usePrivateBrowsing directly.
Reporter | ||
Updated•12 years ago
|
Blocks: pbngentest
Updated•12 years ago
|
Assignee: nobody → marioalv.mozilla
Assignee | ||
Updated•12 years ago
|
Status: NEW → ASSIGNED
Assignee | ||
Comment 1•12 years ago
|
||
Attachment #683439 -
Flags: review?(ehsan)
Assignee | ||
Comment 2•12 years ago
|
||
Removed an unused function from the patch.
Attachment #683439 -
Attachment is obsolete: true
Attachment #683439 -
Flags: review?(ehsan)
Attachment #683623 -
Flags: review?(ehsan)
Reporter | ||
Updated•12 years ago
|
Attachment #683623 -
Flags: review?(ehsan) → review+
Reporter | ||
Comment 3•12 years ago
|
||
http://hg.mozilla.org/integration/mozilla-inbound/rev/bc10a4e38e7a
Comment 4•12 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/bc10a4e38e7a
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 20
You need to log in
before you can comment on or make changes to this bug.
Description
•