806725 - Port test_localStorageBasePrivateBrowsing.html to the new per-tab PB APIs

Status: RESOLVED FIXED

(Firefox :: Private Browsing, defect)

Description

[(no longer active)]

http://mxr.mozilla.org/mozilla-central/source/dom/tests/mochitest/localstorage/test_localStorageBasePrivateBrowsing.html

In order to port this test, the file needs to be copied to the same directory (perhaps with "_perwindowpb" appended to its file name), and then instead of setting privateBrowsingEnabled, we need to open a new private browsing window and then run the test on that window.  Note that the original test should only be added to the list of test files in Makefile.in ifndef MOZ_PER_WINDOW_PRIVATE_BROWSING, and the new test file should be added to the list with the reverse condition.

Comment 1

[(no longer active)]

Removed this test from per-window PB builds: https://hg.mozilla.org/mozilla-central/rev/3c0945f95ceb

Comment 2

[Bellindira Castillo [:bellindira]]

Attachment: Ported testcase

The test is ported however it looks like localStorage works different on private browsing per window than on previous private browsing mode. Because once a new private browsing window is opened and closed, it is not possible to get the values of previous saved items in a normal window. As you will see when running this test, it will throw this error:

113 ERROR TEST-UNEXPECTED-FAIL | chrome://mochitests/content/chrome/dom/tests/mochitest/localstorage/test_localStorageBasePrivateBrowsing_perwindowpb.html | back in normal mode - got null, expected persistent1
make: *** [mochitest-chrome] Error 1

Please let me know what I should do on this check.

Thanks

Comment 3

[(no longer active)]

That seems wrong.  Josh is looking into this.

Comment 4

[Josh Matthews [:jdm]]

Attachment: patch

The test passes with these changes.

Comment 5

[(no longer active)]

Comment on attachment 691548 [details] [diff] [review]
patch

Review of attachment 691548 [details] [diff] [review]:
-----------------------------------------------------------------

I have some indentation nits which I fixed myself.  :-)  Thanks everyone!

Comment 6

[(no longer active)]

https://hg.mozilla.org/mozilla-central/rev/fd919eb97465

Comment 7

[Raymond Lee [:raymondlee]]

This is a typo in this patch.

http://mxr.mozilla.org/mozilla-central/source/dom/tests/mochitest/localstorage/test_localStorageBasePrivateBrowsing_perwindowpb.html?force=1#42

win.removeEventListener("DOMConten/tLoaded", onInnerLoad, true);

Comment 8

[Bellindira Castillo [:bellindira]]

Attachment: Fixed typo

Comment 9

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/3e9f8f3605bb

Comment 10

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/3e9f8f3605bb