806980 - [AccessFu] incremental build improvement

Status: RESOLVED FIXED

(Core :: Disability Access APIs, defect)

Description

[David Bolter [:davidb] (NeedInfo me for attention)]

Attachment: fix

I described some issues I was seeing with changes to accessfu not migrating for incremental builds. It might only happen on mac.

I'll attach the fix Ted suggested.

Comment 1

[Eitan Isaacson [:eeejay]]

Comment on attachment 676625 [details] [diff] [review]
fix

I don't have much to give feedback here for. The build system is a mystery to me. But if this solves issues, I'm all for it.

Comment 2

[(not currently active) Ted Mielczarek]

Comment on attachment 676625 [details] [diff] [review]
fix

Review of attachment 676625 [details] [diff] [review]:
-----------------------------------------------------------------

::: accessible/src/jsat/Makefile.in
@@ +10,5 @@
>  include $(DEPTH)/config/autoconf.mk
>  
> +INSTALL_TARGETS += ACCESSFU
> +
> +ACCESSFU_FILES = \

nit: you could use := here

Comment 3

[David Bolter [:davidb] (NeedInfo me for attention)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/dc436cae60fc

(I confirmed this patch WFM. Pushed with nit fix.)

Comment 4

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/dc436cae60fc