807213 - Stop creating nsSVGMarkerProperty objects for non-nsSVGPathGeometryFrame frames

Status: RESOLVED FIXED

(Core :: SVG, defect)

Description

[Jonathan Watt [:jwatt]]

The only frame type that uses SVG markers is nsSVGPathGeometryFrame. We should stop wastefully creating nsSVGMarkerProperty objects for other frame types.

Comment 1

[Jonathan Watt [:jwatt]]

Attachment: patch

Comment 2

[Jonathan Watt [:jwatt]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/734c42e76813

Comment 3

[Abhishek Arya]

Looking forward to tmrw when it lands to mozilla-central :) and i can reenable fuzzing markers :)

Comment 4

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/734c42e76813

Comment 5

[Jonathan Watt [:jwatt]]

Comment on attachment 676899 [details] [diff] [review]
patch

We should take this on branches.

Comment 6

[Lukas Blakk [:lsblakk] use ?needinfo]

Comment on attachment 676899 [details] [diff] [review]
patch

As per email, go ahead with uplift on this, we know the risk to be low.  I'm clearing the ESR17 flag since we'll get this on the first ESR17 by virtue of it getting on mozilla-beta now (17).

Comment 7

[Jonathan Watt [:jwatt]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/062ae9c63641
https://hg.mozilla.org/releases/mozilla-beta/rev/f6d38889deab

Comment 8

[Daniel Veditz [:dveditz]]

Jonathan: is this fixing a long-standing issue or is this fixing a regression in Firefox 17?

Comment 9

[Jonathan Watt [:jwatt]]

The patch fixes a long-standing issue in the code, although it's unclear what the consequences of that issue are in the various versions of Firefox.