Closed
Bug 807451
Opened 12 years ago
Closed 12 years ago
Remove nsISignatureVerifier and/or nsISignatureVerifier::VerifySignature
Categories
(MailNews Core :: Backend, defect)
MailNews Core
Backend
Tracking
(Not tracked)
RESOLVED
FIXED
Thunderbird 19.0
People
(Reporter: standard8, Assigned: standard8)
References
(Blocks 1 open bug)
Details
Attachments
(1 file)
8.77 KB,
patch
|
neil
:
review+
|
Details | Diff | Splinter Review |
+++ This bug was initially created as a clone of Bug #805305 +++ This does a public key operation on the main thread. It is not used by any addons on AMO (according to MXR) and it's only use within Gecko will go away soon. MailNews uses it, but only to initialize PSM and/or to check if PSM exists; I will provide MailNews with another technique for initializing PSM.
Assignee | ||
Comment 1•12 years ago
|
||
This does what Brian suggests in bug 805305 comment 1. It looks like all but one of the cases were detecting if psm was included or not (which really should have been build config switches!).
Comment 2•12 years ago
|
||
Comment on attachment 677148 [details] [diff] [review] The fix [Surely the correct way to do these checks would have been to try to instantiate the appropriate auth module? Also, interesting that IMAP doesn't even bother.]
Attachment #677148 -
Flags: review?(neil) → review+
Assignee | ||
Comment 3•12 years ago
|
||
https://hg.mozilla.org/comm-central/rev/b2d52e305718
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Flags: in-testsuite-
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 19.0
Comment 4•11 years ago
|
||
I wasted 2 days on looking for the reason why this interface is not usable with javascript. It does not even show up in the firefox. eventually, I came to here. I would say, this interface is not bad. if you can keep it, then with window.crypto.signText, I can sign on something and with this iterface, I can verify something. This interface is especially good to be called from content page. since it does not require the caller to find the certificate. can we keep this and make it scriptable? or add it to the crypto?
You need to log in
before you can comment on or make changes to this bug.
Description
•