Closed
Bug 807556
Opened 12 years ago
Closed 12 years ago
Remove imgIRequest::loadImage's aRequest argument
Categories
(Core :: Graphics: ImageLib, defect)
Core
Graphics: ImageLib
Tracking
()
RESOLVED
FIXED
mozilla19
People
(Reporter: seth, Assigned: seth)
References
(Blocks 1 open bug)
Details
(Keywords: addon-compat)
Attachments
(1 file, 2 obsolete files)
26.41 KB,
patch
|
seth
:
review+
|
Details | Diff | Splinter Review |
imgIRequest::loadImage will be capable of returning multiple types of objects with different sizes once bug 790640 is complete. This means that the |aRequest| argument, which allows the caller to provide an existing imgIRequest object to be filled in, is no longer safe; we won't be able to reuse the existing object if we need to return one of a different type. With respect to our own code, this is a low-impact change; there were no callers passing anything other than NULL in our codebase.
Assignee | ||
Comment 1•12 years ago
|
||
Proposed patch. Eventually r=joe, but since this is an addon-accessible API I'd like to get feedback from Jorge.
Attachment #677253 -
Flags: feedback?(jorge)
Assignee | ||
Comment 2•12 years ago
|
||
Try job running here: https://tbpl.mozilla.org/?tree=Try&rev=adef227ac8dc
Comment 3•12 years ago
|
||
Try run for adef227ac8dc is complete. Detailed breakdown of the results available here: https://tbpl.mozilla.org/?tree=Try&rev=adef227ac8dc Results (out of 153 total builds): success: 139 warnings: 6 failure: 8 Builds (or logs if builds failed) available at: http://ftp.mozilla.org/pub/mozilla.org/firefox/try-builds/mfowler@mozilla.com-adef227ac8dc
Comment 4•12 years ago
|
||
Try run for adef227ac8dc is complete. Detailed breakdown of the results available here: https://tbpl.mozilla.org/?tree=Try&rev=adef227ac8dc Results (out of 154 total builds): success: 139 warnings: 6 failure: 9 Builds (or logs if builds failed) available at: http://ftp.mozilla.org/pub/mozilla.org/firefox/try-builds/mfowler@mozilla.com-adef227ac8dc
Assignee | ||
Comment 5•12 years ago
|
||
Missed a call to LoadImage in toolkit/system/gnome. (This call, too, passed null for aRequest.)
Attachment #677253 -
Attachment is obsolete: true
Attachment #677253 -
Flags: feedback?(jorge)
Attachment #677449 -
Flags: feedback?(jorge)
Assignee | ||
Comment 6•12 years ago
|
||
Running a new try job here: https://tbpl.mozilla.org/?tree=Try&rev=ae5f49d1140b
Comment 7•12 years ago
|
||
Comment on attachment 677449 [details] [diff] [review] Remove imgIRequest::loadImage's aRequest argument. I didn't find any add-ons using this on AMO. I'll just flag this bug for addon-compat to mention it in the compatibility blog post, but I don't think this will be a problem for add-ons.
Attachment #677449 -
Flags: feedback?(jorge) → feedback+
Updated•12 years ago
|
Keywords: addon-compat
Assignee | ||
Comment 8•12 years ago
|
||
Thanks Jorge! Try looks OK; requesting review.
Assignee | ||
Updated•12 years ago
|
Attachment #677449 -
Flags: review?(joe)
Comment 9•12 years ago
|
||
Comment on attachment 677449 [details] [diff] [review] Remove imgIRequest::loadImage's aRequest argument. Review of attachment 677449 [details] [diff] [review]: ----------------------------------------------------------------- You need to fix the javascript unit tests that call loadImage manually too, though those should show up in try. ::: image/public/imgILoader.idl @@ +42,2 @@ > * @param aReferrerURI the 'referring' URI > * @param aLoadingPrincipal the principal of the loading document You need to change the imgILoader uuid.
Attachment #677449 -
Flags: review?(joe) → review+
Comment 10•12 years ago
|
||
Try run for ae5f49d1140b is complete. Detailed breakdown of the results available here: https://tbpl.mozilla.org/?tree=Try&rev=ae5f49d1140b Results (out of 244 total builds): exception: 1 success: 221 warnings: 13 failure: 9 Builds (or logs if builds failed) available at: http://ftp.mozilla.org/pub/mozilla.org/firefox/try-builds/mfowler@mozilla.com-ae5f49d1140b
Assignee | ||
Comment 11•12 years ago
|
||
Thanks Joe. I made the changes you suggested. Carrying over r+. Running a new try job at https://tbpl.mozilla.org/?tree=Try&rev=a338f4c05769. If try looks good this'll be ready for checkin.
Attachment #677449 -
Attachment is obsolete: true
Attachment #677584 -
Flags: review+
Comment 12•12 years ago
|
||
Try run for ae5f49d1140b is complete. Detailed breakdown of the results available here: https://tbpl.mozilla.org/?tree=Try&rev=ae5f49d1140b Results (out of 245 total builds): exception: 1 success: 221 warnings: 13 failure: 10 Builds (or logs if builds failed) available at: http://ftp.mozilla.org/pub/mozilla.org/firefox/try-builds/mfowler@mozilla.com-ae5f49d1140b
Comment 13•12 years ago
|
||
Try run for a338f4c05769 is complete. Detailed breakdown of the results available here: https://tbpl.mozilla.org/?tree=Try&rev=a338f4c05769 Results (out of 252 total builds): exception: 1 success: 228 warnings: 11 failure: 12 Builds (or logs if builds failed) available at: http://ftp.mozilla.org/pub/mozilla.org/firefox/try-builds/mfowler@mozilla.com-a338f4c05769
Assignee | ||
Comment 14•12 years ago
|
||
Ack, try run was checking against an old version of mozilla-central. One more try run.. sigh.. https://tbpl.mozilla.org/?tree=Try&rev=187c3df45f66
Assignee | ||
Comment 15•12 years ago
|
||
The previous two runs had in common that they showed failures on Android ARMv6. I am virtually certain that those failures are not caused by those patch, but I'm running a comparison just to be sure here: https://tbpl.mozilla.org/?tree=Try&rev=4c220c375c67
Assignee | ||
Comment 16•12 years ago
|
||
A typo resulted in the try results not automatically being posted here, but they're done. (https://tbpl.mozilla.org/?tree=Try&rev=187c3df45f66) Everything looks OK. Requesting checkin.
Assignee | ||
Updated•12 years ago
|
Keywords: checkin-needed
Comment 17•12 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/38b97d2a1bc5
Flags: in-testsuite-
Keywords: checkin-needed
Comment 18•12 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/38b97d2a1bc5
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla19
You need to log in
before you can comment on or make changes to this bug.
Description
•