807760 - Only enable OMTC for certain platforms

Status: RESOLVED FIXED

(Firefox OS Graveyard :: General, defect)

Description

[Josh Matthews [:jdm]]

Currently b2g.js unconditionally enables OMTC. This is bad for local desktop builds, and possibly desktop nightlies. We should disable it at least for Windows, where I've seen it cause startup crashes.

Comment 1

[Josh Matthews [:jdm]]

Attachment: Disable OMTC in b2g builds on Windows.

Comment 2

[Myk Melez [:myk] [@mykmelez]]

In my testing, disabling OMTC on Windows does enable B2G to start up without crashing, but it has a couple side-effects: the B2G wallpaper is replaced by a black background; and a mouse click-and-drag, which simulates a finger swipe on an actual device, doesn't cause a repaint until the next event is dispatched.

Comment 3

[Chris Jones [:cjones] inactive; ni?/f?/r? if you need me]

Comment on attachment 677525 [details] [diff] [review]
Disable OMTC in b2g builds on Windows.

You can drop the #else because this defaults to false.  Please link a FIXME/bug XXXXX in a comment here.

r=me with that

Comment 4

[Josh Matthews [:jdm]]

Chris, should this be disabled for desktop builds in general, since it's a fairly unsupported setup at this point? Are we able to differentiate between device and desktop builds?

Comment 5

[Chris Jones [:cjones] inactive; ni?/f?/r? if you need me]

It's also disabled on x11 builds, although that's not obvious from the pref.  (x11 is a special snowflake.)

My understanding is that omtc on mac is pretty stable, but I don't use a mac so I don't have firsthand evidence.  CC'ing some folks who know better.

Comment 6

[Benoit Girard (:BenWa)]

I ran OMTC mac build by default for daily browsing for about a month where it was stable minus a few buffer rotation bugs. And if it isn't then we've got a regression on our hands.

Comment 7

[Nick Cameron [:nrc]]

OMTC mac is fine right now, at least for casual browsing (I'm not using it full time, but I haven't seen it crash or mis-render for a long time).

Comment 8

[Josh Matthews [:jdm]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/12ac23e3c313 and comment followup in https://hg.mozilla.org/integration/mozilla-inbound/rev/49e7c88df185.

Comment 9

[Josh Matthews [:jdm]]

Comment on attachment 677525 [details] [diff] [review]
Disable OMTC in b2g builds on Windows.

[Approval Request Comment]
Bug caused by (feature/regressing bug #): 
User impact if declined: Startup crashes for windows b2g desktop builds.
Testing completed (on m-c, etc.): Multiple b2g desktop builds across several machines that did not start and now do.
Risk to taking this patch (and alternatives if risky): The risk of shipping a desktop build that is actually usable.
String or UUID changes made by this patch: None.

Comment 10

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/12ac23e3c313
https://hg.mozilla.org/mozilla-central/rev/49e7c88df185

Comment 11

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/c8a04a9e8a3f
https://hg.mozilla.org/releases/mozilla-aurora/rev/76e2abf198c0