807814 - Make it more obvious the device type selector allows multiple selections

Status: VERIFIED FIXED

(Marketplace Graveyard :: Developer Pages, defect)

Description

[Potch [:potch]]

It's not obvious that you can pick more than one device type. We should make it obvious. I'm not above language like "choose at least one".

Comment 1

[Wil Clouser [:clouserw]]

You're talking about on https://bug794695.bugzilla.mozilla.org/attachment.cgi?id=677310 ?

Comment 2

[Potch [:potch]]

I war referring to http://cl.ly/image/2N3v1d0l2g1G, but similar criticism applies to your screenshot.

Comment 3

[Christopher Van Wiemeersch [:cvan]]

There used to be checkboxes, which IMO makes it very obvious.

Comment 4

[Christopher Van Wiemeersch [:cvan]]

https://github.com/mozilla/zamboni/commit/29bb5a9

I think Maria and/or Bram didn't want checkboxes, but this looks clearer to me. If someone has better styles, feel free to take a stab.

http://cl.ly/image/1y0i1w1k3S3V/o

Comment 5

[Maria Sandberg [:mushi]]

ccing Bram. 

I agree that the checkboxes make it more apparent that you can choose multiple. It's not the best visual treatment but we can improve that later with Mike's help. 

Bram, I know there were designs with both checkboxes and without them - what's your recommendation?

Comment 6

[Bram Pitoyo [:bram]]

I designed the device type selector with checkboxes, but neglect to include it in later mockups. As a result, the checkboxes didn’t get implemented.

For reference, see the very first mockup on attachment 672677 [details]. It’s very similar to what cvan proposed on comment 4. Feel free to implement that design.

I agree with Maria that the checkboxes don’t have the best visual. But it’s the right mental model to convey the idea that user can select multiple items.

Comment 7

[Bram Pitoyo [:bram]]

cvan’s current solution that I see on marketplace-dev.allizom already works well, by the way.

Comment 8

[krupa raj[:krupa]]

verified fixed at https://marketplace-dev.allizom.org/developers/submit/app/manifest