Closed Bug 807843 Opened 12 years ago Closed 6 years ago

Stringify process number in devicemanagerADB

Categories

(Testing :: Mochitest, defect)

x86
Linux
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED WONTFIX

People

(Reporter: wesj, Unassigned)

Details

Attachments

(1 file)

Attached patch PatchSplinter Review
We're not stringify the process name in killProcess. That leads to tests not running.
Attachment #677603 - Attachment is patch: true
Attachment #677603 - Flags: review?(jmaher)
Comment on attachment 677603 [details] [diff] [review]
Patch

Review of attachment 677603 [details] [diff] [review]:
-----------------------------------------------------------------

good catch.  We have a few consumers of devicemanagerADB so we need to be careful with this, specifically the Marionette B2G emulator tests.
Attachment #677603 - Flags: review?(jmaher) → review+
This is apparently checked in on github, but not synced with mc:

https://github.com/mozilla/mozbase/commit/94e9a49155de4a03467a5d68fc5cfec03953bb06
Mass closing mochitest bugs that haven't had activity in the past 5 years. Please re-open or file a new bug with modern context if this is still relevant.
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → WONTFIX
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: