808024 - Persona login is broken when marketplace serves double slash URLs

Status: RESOLVED DUPLICATE of bug 813171

(Marketplace Graveyard :: Consumer Pages, defect)

Description

[Florin Strugariu [:Bebe]]

Attachment: screenshot with the error page

Open https://marketplace-dev.allizom.org/developers/
Click Login

Expected
User should login as expected.

Actual:
Our tests return a browserId error message

http://qa-selenium.mv.mozilla.com:8080/job/marketplace.dev.developer_hub/154/HTML_Report/?

Comment 1

[Florin Strugariu [:Bebe]]

This is not reproducible logging in manually

Comment 2

[Lloyd Trevor Hilaiel]

steps to reproduce:

1. open https://marketplace-dev.allizom.org//developers/
2. click login

notice the double slash in the url

problem description:
  * tests are invoked with --baseurl=https://marketplace-dev.allizom.org/
  * pom stuff creates urls with double slashes in the path https://github.com/lloyd/marketplace-tests/blob/master/pages/desktop/developer_hub/home.py#L18
  * marketplace happily serves up content with double slashes
  * persona hates double slashes https://github.com/mozilla/browserid/blob/dev/resources/static/dialog/js/modules/dialog.js#L110

On the persona side I will investigate why we are hating on double slashes.

On the marketplace side there are several ways to resolve:
1. redirect users from //foo to /foo
2. remove trailing slash in base_url
3. change test code to dedup slashes

Comment 3

[Kumar McMillan [:kumar]]

Good catch, thanks. We should at least redirect //foo to /foo to prevent this from happening. The selenium tests should also be updated.

Comment 4

[Lloyd Trevor Hilaiel]

for completeness, here is where the change was introduced that got us hating double slash '//': https://github.com/mozilla/browserid/pull/2480

Comment 5

[Matt Basta [:basta]]

How is this related to double slashes? The problem reproduces without the double slashes. This error is occurring because /browserid-login throws a 403.

Comment 6

[Florin Strugariu [:Bebe]]

I will update the tests to use single slash url and will add a special login testcase that will check that a user can login if he uses a double slash url

Comment 7

[Florin Strugariu [:Bebe]]

Fix and new test for our tests

https://github.com/mozilla/marketplace-tests/pull/166

Comment 8

[Wil Clouser [:clouserw]]

Florin filed another more generic bug.  It's the same thing, so duping to that.