Closed Bug 808518 Opened 12 years ago Closed 12 years ago

[contacts] Address info from Facebook should be disabled in edit contact

Categories

(Firefox OS Graveyard :: Gaia, defect)

Product:
Firefox OS Graveyard
Component:
Gaia
Platform:
x86
Gonk (Firefox OS)
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(blocking-basecamp:-)

Status:
VERIFIED FIXED
Project Flags:
blocking-basecamp -

People

(Reporter: crdlc, Assigned: crdlc)

Details

(Keywords: polish)

Attachments

(1 file, 1 obsolete file)

Added tests
5.22 KB, text/plain
arcturus
: review+
arcturus
: approval-gaia-v1+
Details 
The address info should be disabled when it is provided by Facebook in edit mode view
Assignee: nobody → crdlc
Status: NEW → ASSIGNED
blocking-basecamp: --- → ?
Attached file Fixed (obsolete) — 

        Attachment #678259 -
        Flags: review?(francisco.jordano)

        Attachment #678259 -
        Flags: review?(francisco.jordano) → review+

    
    

    
  
Cristian can we add some unit tests for this change?

    
    

    
  
yes I can in one hour

    
    

    
  

      
      
      
      

        Attached file
          
        Added tests
        — 
      

    


  

        Attachment #678259 -
        Attachment is obsolete: true

        Attachment #678692 -
        Flags: review?(francisco.jordano)

        Attachment #678692 -
        Flags: review?(francisco.jordano) → review+

    
    

    
  
Comment on attachment 678692 [details]
Added tests

NOTE: If blocking-basecamp+ is set, just land it for now.

[Approval Request Comment]
Bug caused by (feature/regressing bug #): 
User impact if declined: 
Testing completed: 
Risk to taking this patch (and alternatives if risky):

        Attachment #678692 -
        Flags: approval-gaia-master?(francisco.jordano)

        Attachment #678692 -
        Flags: approval-gaia-master?(francisco.jordano) → approval-gaia-master+

    
    

    
  
https://github.com/mozilla-b2g/gaia/commit/2ba223a3fb6d654ca765f00e5c439e932353584d
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
blocking-basecamp: ? → -
Keywords: polish

    
    

    
  
Verified on Unagi build id:20130102070202
Status: RESOLVED → VERIFIED

          You need to log in
          before you can comment on or make changes to this bug.
        






  

    
  







  

    

      
Attachment

      

      
      
      
      
    

    

      

        

          

            
General

            

              Creator: 



            

            
Created: 

            
Updated: 

            
Size: