Closed
Bug 808524
Opened 12 years ago
Closed 12 years ago
remove unused folderTargetPopup class and binding
Categories
(MailNews Core :: Backend, defect)
MailNews Core
Backend
Tracking
(Not tracked)
RESOLVED
FIXED
Thunderbird 19.0
People
(Reporter: aceman, Assigned: aceman)
References
Details
Attachments
(1 file, 1 obsolete file)
10.47 KB,
patch
|
aceman
:
review+
mconley
:
review+
|
Details | Diff | Splinter Review |
Remove the unused folderTargetPopup class and binding. It is now possible after bug 315367. http://mxr.mozilla.org/comm-central/search?string=folderTargetPopup&find=&findi=&filter=^[^\0]*%24&hitlimit=&tree=comm-central This can be done for both Thunderbird and Seamonkey. Also add missing class="menulist-menupopup" to the menupopup searchWidgets.xml, binding id="ruleactiontarget-folder" which was recently converted away from class="folderTargetPopup".
Attachment #678426 -
Flags: review?(neil)
Comment 2•12 years ago
|
||
Comment on attachment 678426 [details] [diff] [review] patch >- <xul:menupopup type="folder" >+ <xul:menupopup class="menulist-menupopup" >+ type="folder" No need to reorder the attributes, just add the class on its own line. r=me with that fixed.
Attachment #678426 -
Flags: review?(neil) → review+
Comment 3•12 years ago
|
||
(Also don't forget to port the class change to any appropriate branches.)
Bug 315367 is in TB19 trunk, so no branches have it yet.
Thanks.
Attachment #678426 -
Attachment is obsolete: true
Attachment #678800 -
Flags: review+
Keywords: checkin-needed
Comment 6•12 years ago
|
||
https://hg.mozilla.org/comm-central/rev/73850fe23239
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Flags: in-testsuite-
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 19.0
Ryan, if it is possible to fix the checkin message, could you please remove mconley as did not review this.
Comment 8•12 years ago
|
||
I'd have to backout and re-land to do that. Is it really worth it?
Comment on attachment 678800 [details] [diff] [review] patch v2 So let's try to get his review and then we do not need to back out ;)
Attachment #678800 -
Flags: review?(mconley)
Comment 10•12 years ago
|
||
Comment on attachment 678800 [details] [diff] [review] patch v2 Review of attachment 678800 [details] [diff] [review]: ----------------------------------------------------------------- LGTM, thanks!
Attachment #678800 -
Flags: review?(mconley) → review+
You need to log in
before you can comment on or make changes to this bug.
Description
•