808545 - Tweak the exception message for runxpcshelltests.py profile cleanup failures

Status: RESOLVED FIXED

(Testing :: XPCShell Harness, defect)

Description

[Ed Morley [:emorley]]

At the moment we use:
sys.exc_info()[0]
...which gives us:
TEST-UNEXPECTED-FAIL | /builds/slave/talos-slave/test/build/xpcshell/tests/services/aitc/tests/unit/test_aitc_client.js | Failed to clean up the test profile directory: <type 'exceptions.OSError'>

I think it would be clearer to use:
sys.exc_info()[1]
...which should give us something like:
TEST-UNEXPECTED-FAIL | /builds/slave/talos-slave/test/build/xpcshell/tests/services/aitc/tests/unit/test_aitc_client.js | Failed to clean up the test profile directory: [Errno 13] Permission denied: '/var/folders/wq/fgxf4g514bn06sl6r8202x6r00000w/T/tmpGDAdQc/Cache'

Comment 1

[Ed Morley [:emorley]]

Attachment: Patch v1

Comment 2

[Ed Morley [:emorley]]

Thank you for the review :-)

https://hg.mozilla.org/integration/mozilla-inbound/rev/0a6cb7947e07

Comment 3

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/0a6cb7947e07

Comment 4

[Ed Morley [:emorley]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/db70683ea79f
https://hg.mozilla.org/releases/mozilla-beta/rev/1651fc592d90