Closed Bug 809293 Opened 12 years ago Closed 12 years ago

[Settings] developer info in Application Permissions always links to http://github.com/mozilla-b2g/gaia/

Categories

(Firefox OS Graveyard :: Gaia::Settings, defect, P3)

Product:
Firefox OS Graveyard
Component:
Gaia::Settings
Platform:
All
Gonk (Firefox OS)
Type:
defect

Tracking

(blocking-basecamp:+)

Status:
VERIFIED FIXED
Project Flags:
blocking-basecamp +

People

(Reporter: MattN, Assigned: MattN)

Details

(Keywords: b2g-testdriver)

Attachments

(1 file)

Pointer to Github pull request: https://github.com/mozilla-b2g/gaia/pull/6226
355 bytes, text/html
etienne
: review+
Details 
developerName.href never gets changed from http://github.com/mozilla-b2g/gaia/ in apps/settings/js/apps.js

Clicking on the developer name always links to http://github.com/mozilla-b2g/gaia/
Pointer to Github pull-request
Attachment #679020 - Flags: review?(21)
This was because the code only looked at the data-href for external URLs but that was not getting updated when switching apps in the permission screen. While fixing this I realized it also affected the developer's URL line as well.
Summary: [Settings] developer name in Application Permissions always links to http://github.com/mozilla-b2g/gaia/ → [Settings] developer info in Application Permissions always links to http://github.com/mozilla-b2g/gaia/
Comment on attachment 679020 [details]
Pointer to Github pull request: https://github.com/mozilla-b2g/gaia/pull/6226

Mostly Etienne's code. Let's redirect the review.
Attachment #679020 - Flags: review?(21) → review?(etienne)
Hey Matthew, commented on the pull request, just a small change needed.

Thanks for the fix!
Attachment #679020 - Flags: review?(etienne) → review+
blocking-basecamp: ? → +
Priority: -- → P3
Keywords: verifyme
QA Contact: jsmith
Component: Gaia::Apps Management → General
Component: General → Gaia
Component: Gaia → Gaia::Settings
Looks good. Verified on 11/26.
Status: RESOLVED → VERIFIED
Keywords: verifyme
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: