Closed
Bug 809328
Opened 12 years ago
Closed 12 years ago
Stop using nsChangeHint_UpdateEffects in nsSVGRenderingObserver::DoUpdate overrides
Categories
(Core :: SVG, defect)
Core
SVG
Tracking
()
RESOLVED
FIXED
mozilla19
People
(Reporter: jwatt, Assigned: jwatt)
Details
(Keywords: perf)
Attachments
(1 file)
|
1.82 KB,
patch
|
roc
:
review+
|
Details | Diff | Splinter Review |
nsSVGEffects::UpdateEffects is meant to be called when changes to an element that is using SVG effects (e.g. CSS property changes) cause its frame to start/stop referencing (or reference different) SVG effects frames. Calling it when the referenced resources change is wasteful, so we should stop doing that. FWIW we didn't used to do this. The use of nsChangeHint_UpdateEffects was added to nsSVGFilterProperty::DoUpdate in bug 458493, and to nsSVGMarkerProperty::DoUpdate in bug 472135.
|
Assignee | |
Comment 1•12 years ago
|
||
Attachment #679040 -
Flags: review?(roc)
|
|
Assignee | |
Updated•12 years ago
|
Version: 17 Branch → Trunk
Attachment #679040 -
Flags: review?(roc) → review+
|
||
Comment 2•12 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/cbafefd68d1c
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla19
You need to log in
before you can comment on or make changes to this bug.
Description
•