809751 - presentational table related elements referred or having global ARIA attributes must be accessible

Status: RESOLVED FIXED

(Core :: Disability Access APIs, defect)

Description

[alexander :surkov (:asurkov)]

1) having global ARIA attribute:

https://dvcs.w3.org/hg/pfwg/file/c9aa483b06ca/ARIA/1.0/tests/test-files/presentation-role/521.html

<table role="presentation">
<tr>
<td aria-hidden="true">Test me</td>
</tr>
</table>

2) referred by ARIA relation:

https://dvcs.w3.org/hg/pfwg/file/c9aa483b06ca/ARIA/1.0/tests/test-files/presentation-role/524.html

<table role="presentation">
<tr>
<td aria-labelledby="foo"></td>
</tr>
</table>
<div id="foo">test</div>

Comment 1

[alexander :surkov (:asurkov)]

plush many other dupe failures: https://wiki.mozilla.org/Accessibility/ARIA1.0TestSuiteFailures#521

Comment 2

[alexander :surkov (:asurkov)]

Attachment: patch

Comment 3

[Trevor Saunders (:tbsaunde)]

Comment on attachment 679653 [details] [diff] [review]
patch

diff --git a/accessible/src/base/nsAccessibilityService.cpp b/accessible/src/base/nsAccessibilityService.cpp
--- a/accessible/src/base/nsAccessibilityService.cpp
+++ b/accessible/src/base/nsAccessibilityService.cpp
 ////////////////////////////////////////////////////////////////////////////////
+// Statics
+////////////////////////////////////////////////////////////////////////////////

so what exactly is the point of these comments? they seem to be there just to get out of date as we move things around...

+      if (attrFlags & ATTR_GLOBAL) {
+        if ((attrFlags & ATTR_VALTOKEN) &&
+            !nsAccUtils::HasDefinedARIAToken(aContent, attrAtom))
+          continue; // token and not defined

make the same if?

Comment 4

[alexander :surkov (:asurkov)]

(In reply to Trevor Saunders (:tbsaunde) from comment #3)

> so what exactly is the point of these comments?

we have sections, keeping this method under nsAccessibilityService section doesn't seem right

> they seem to be there just
> to get out of date as we move things around...

true

> +      if (attrFlags & ATTR_GLOBAL) {
> +        if ((attrFlags & ATTR_VALTOKEN) &&
> +            !nsAccUtils::HasDefinedARIAToken(aContent, attrAtom))
> +          continue; // token and not defined
> 
> make the same if?

ok

Comment 5

[alexander :surkov (:asurkov)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/f00ea0cb7b50

Comment 6

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

Comment on attachment 679653 [details] [diff] [review]
patch

Review of attachment 679653 [details] [diff] [review]:
-----------------------------------------------------------------

::: accessible/src/base/nsAccessibilityService.cpp
@@ +91,5 @@
> +  if (aContent->GetPrimaryFrame()->IsFocusable())
> +    return true;
> +
> +  PRUint32 attrCount = aContent->GetAttrCount();
> +  for (PRUint32 attrIdx = 0; attrIdx < attrCount; attrIdx++) {

Hey guys, next time please keep in mind that we use uint32_t now. Thanks!

Comment 7

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/f00ea0cb7b50

Comment 8

[alexander :surkov (:asurkov)]

(In reply to :Ms2ger from comment #6)

> > +  PRUint32 attrCount = aContent->GetAttrCount();
> > +  for (PRUint32 attrIdx = 0; attrIdx < attrCount; attrIdx++) {
> 
> Hey guys, next time please keep in mind that we use uint32_t now. Thanks!

sorry, old habits die hard